[08:06:59] effie: hey! I'm about to start playing with helm test on the taging cluster in a bit. If you want me to wait, let me know. [08:07:27] I am around go ahead please [08:07:46] I am listening to black sabbath, so this will certainly go well [08:08:46] :P [08:09:26] don't be, you know, paranoid ;) [08:11:17] luckily it is not in this album haha [08:34:25] effie: so... I was hoping i could test this without mewrging into master, just from my home dir. that's what claime recommended. But I can't, because I need the updated chart bundle. [08:36:04] duesen: can I see the change? [08:36:32] If I merge the patch and then revert it, what happens to that chart package? Can I somehow still force it to be used? Or can I build and publish the package without merging the patch? I'd use a a chart number like 0.15.100-experimental-thing [08:36:43] https://gerrit.wikimedia.org/r/c/operations/deployment-charts/+/1282965 [08:36:59] It adds a test temnplate to the chart. it should be a no-op in production. [08:37:14] but helm test wants the ttest to be part of the chart, that's the point. [08:39:37] to my understanding, if you have not bumped the chart version, this will indeed be no op in prod [08:40:42] I think maybe claime can provide a better answer here, to me it seems that you can merge and revert without affecting prod [08:40:51] but i need to bump the chart version, because i need the new template in the chart [08:41:15] yes, i can merge and revert, but... how do I test, then? [08:41:45] How does helmfile pick which chart bundle it uses? semver? [08:41:54] help me understadn here, you would like to run some tests manually [08:42:39] which are defined there, and some of them are for CI [08:42:40] I want to manually tell hlem to run system integration tests that are deployed as part of the chart. [08:43:01] that was the part I was missing [08:43:15] wait [08:43:16] sorry. [08:43:20] i gave you two wrong link [08:43:35] ? [08:43:36] I *also* work on tests for ci, but that's unrelated. sorry [08:43:57] https://gerrit.wikimedia.org/r/c/operations/deployment-charts/+/1267959 [08:44:33] This is where I define a pod to run after deployment, via helm test (or helmfile test). [08:44:59] if you are planning to deloy this on staging and try there [08:45:44] then if it doest work we can revert and just bump the chart version [08:46:14] sounds correct? [08:46:49] claime should be around sometime in the next hour, if you have second thoughts, you can wait for them [08:47:00] if they have more context which I clearly do not have [08:47:09] yes... except that we'd be merging something on master that has EXPERIMENTAL in the title :P [08:48:08] claim assumed you knew the process to try this on your home dir [08:48:22] thus the misunderstanding [08:48:43] I think I'll wait for him to come on. Merging this for experimentation would be safe I think as long as nobody tried to merge and deploy anythign else on top of it before I revert. But merging something very experimental just feels... wrong :) [08:48:51] I am slightly tight up to guide you though it, so here is what we can do [08:49:00] 1. merge and revert, we have done much worse really [08:49:15] 2. wait for claime to help you step by step try this on your homedir [08:49:24] well, i know the process if it's just a value change, but not if it involves a version bump. [08:50:15] #yes, ok, i'll do that. Thanks :) [08:50:23] cheers [09:25:16] duesen: you can pin the chart version in the helmfile [09:26:13] chart: roboll/vault-secret-manager # the chart being installed to create this release, referenced by `repository/chart` syntax [09:26:15] version: ~1.24.1 # the semver of the chart. range constraint is supported [09:27:33] ah i see! i'll play with that later, then. [09:27:48] I merged expermental patches (version 0.15.16), two reverts (to 0.15.15), and one chart bump (to 0.15.17). Can you have a look at the history of the api-gateway chart to make sure I didn't mess this up? [09:28:48] Actually, I see a diff on helmfile.d/ml-services/experimental/values-ml-staging-codfw.yaml locally.... that shouldn't be there... maybe I got confused. [09:32:15] locally in /srv ? [09:32:52] on my laptop, just doing git diff HEAD..13d46740debc0ba417860151355dd46fbf3fc22f [09:33:25] oh, i know why. becausyed that diff skips over an intgermediat commit, 92bbc935af5416de71b7bffc84341fa1e01f724b [09:34:24] that wasn't reverted, should be fine. [09:36:05] ok, so... later, I will make reverts for my reverts. I will check them out in my home dir (but not merge them). I'll edit the hemlfile to pin the chart to version 0.15.16. then i should be able to run the tests. [09:36:19] ...after applying to staging. [09:36:50] yep [09:37:17] * Raine hadn't realised you'd need a chart bump, but it makes sense