[07:49:33] 10netops, 10Infrastructure-Foundations, 10SRE, 10Patch-For-Review: Upgrade core routers to Junos 21+ - https://phabricator.wikimedia.org/T295690 (10ops-monitoring-bot) Icinga downtime and Alertmanager silence (ID=1ea26f52-695b-41ae-a3b4-28808d44161a) set by ayounsi@cumin1001 for 4:00:00 on 3 host(s) and th... [09:29:17] 10netops, 10Infrastructure-Foundations, 10SRE, 10Patch-For-Review: Upgrade core routers to Junos 21+ - https://phabricator.wikimedia.org/T295690 (10ops-monitoring-bot) Icinga downtime and Alertmanager silence (ID=acbab0ff-4998-42b3-b0ad-a6be933dfff6) set by ayounsi@cumin1001 for 4:00:00 on 3 host(s) and th... [09:30:17] hi, I'm scratching my head a little on CI failures for https://gerrit.wikimedia.org/r/c/operations/software/netbox-extras/+/817739 as they are not related to my change, have you seen this before? [09:30:32] 09:26:25 py38-mypy run-test: commands[0] | mypy dns tools/ganeti-netbox-sync.py [09:30:35] 09:26:25 [213] /src$ /src/.tox/py38-mypy/bin/mypy dns tools/ganeti-netbox-sync.py [09:30:38] 09:26:27 dns/generate_dns_snippets.py:303: error: Unused "type: ignore" comment [09:30:41] 09:26:28 Found 1 error in 1 file (checked 2 source files) [09:50:21] 10Puppet, 10Infrastructure-Foundations, 10Patch-For-Review: Ferm unloads all iptables rules when it hits a parsing error - https://phabricator.wikimedia.org/T315305 (10jbond) i think with the merged of 823621 this can be closed please re-open if you still see issues [09:50:43] * jbond godog looking [09:51:02] 10Puppet, 10Infrastructure-Foundations, 10Patch-For-Review: Ferm unloads all iptables rules when it hits a parsing error - https://phabricator.wikimedia.org/T315305 (10jbond) 05Open→03Resolved a:03jbond [09:52:36] cheers jbond ! I can actually reproduce locally on current master too [09:58:59] godog: im gussing it was an ignore to work around a mypy bug that has now been fixed. i have created a patch and rebased yours on it but lets wait for volans to confirm [09:59:27] jbond: makes sense, thank you [09:59:28] fix: https://gerrit.wikimedia.org/r/c/operations/software/netbox-extras/+/836740 [10:00:11] I didn't think of a mypy bug fixed in the meantime [10:01:05] it has happend a couple of times before so not that uncommon [10:04:03] sorry was in a meeting [10:04:16] so basically yes, Unused "type: ignore" means that we ignored some mypy error [10:04:27] and a more recent mypy version is not finding that error on that line [10:04:36] and so tells you that the ignore is not anymore needed [10:04:39] and you can just drop it [10:04:44] cc godog, jbond [10:04:55] got it! thank you for the explanation volans [10:50:25] 10netops, 10Infrastructure-Foundations, 10SRE, 10Patch-For-Review: Upgrade core routers to Junos 21+ - https://phabricator.wikimedia.org/T295690 (10ops-monitoring-bot) Icinga downtime and Alertmanager silence (ID=01f0d013-5101-4278-93a6-1ea49f9dea28) set by ayounsi@cumin1001 for 1:00:00 on 2 host(s) and th... [11:20:39] 10netops, 10Infrastructure-Foundations, 10SRE, 10Patch-For-Review: Upgrade core routers to Junos 21+ - https://phabricator.wikimedia.org/T295690 (10ayounsi) eqiad and eqord went extremely well. Thanks @cmooney for the [[ https://wikitech.wikimedia.org/wiki/Juniper_RE_i40e_firmware | firmware instructions ]] [11:21:25] 10netops, 10Infrastructure-Foundations, 10SRE, 10Patch-For-Review: Upgrade core routers to Junos 21+ - https://phabricator.wikimedia.org/T295690 (10ayounsi) [11:24:47] 10netops, 10Infrastructure-Foundations, 10SRE, 10Patch-For-Review: Upgrade network devices to Junos 20+ - https://phabricator.wikimedia.org/T316539 (10ayounsi) [11:25:21] 10netops, 10Infrastructure-Foundations, 10SRE, 10Patch-For-Review: Upgrade core routers to Junos 21+ - https://phabricator.wikimedia.org/T295690 (10ayounsi) 05Open→03Resolved [13:48:58] 10netops, 10Infrastructure-Foundations, 10SRE, 10ops-eqiad, 10Sustainability (Incident Followup): eqiad row C switch fabric recabling - https://phabricator.wikimedia.org/T313384 (10Jclark-ctr) cableid 2207506656 fpc7 - fpc5 cableid 2207506655 fpc2 - fpc6 cableid 2207506658 fpc7 - fpc3 Ayounsi did you...