[07:27:04] XioNoX: That's rather funny to me: "Invalid DNS name (shouldn't end with a dot)" the in-house build DNS I used previously had the reverse requirement. If you didn't put a . it would assume that you where creating a entry under whatever the current domain was and you'd end up with domain like commons.wikimedia.org.wikimedia.org. [07:41:52] slyngs: the end dot is technically correct, but less user friendly, so we abstract it, especially as it should always be a FQDN [07:43:19] Yeah, we had it in our system because "technically correct", but people forgot all the time and broke records all the time :-) [07:56:13] the check here was also just a proof of concept, but we could imagine it being more thorough, maybe we already have a regex laying around somewhere [08:10:16] There's this https://validators.readthedocs.io/en/latest/_modules/validators/domain.html#domain from the validators Python module, but we would have to remove the trailing dot match anyway [08:15:01] good idea! [10:26:56] ftr the regex linked above dosn't check for a trailing dot, however it dosn;t match srv records or bare tld's both of which are probably ok for our use case) [11:20:40] reviews welcome https://gerrit.wikimedia.org/r/c/operations/software/netbox-extras/+/889958 :) [14:51:23] 10netbox, 10Infrastructure-Foundations, 10Patch-For-Review: Netbox: use Custom Model Validation - https://phabricator.wikimedia.org/T310590 (10ayounsi) I tested the above on netbox-next and fixed some bugs I found. One oversight from yesterday is that in some cases uwsgi needs to be restarted when modifying... [15:02:32] 10netbox, 10Infrastructure-Foundations, 10Patch-For-Review: Netbox: use Custom Model Validation - https://phabricator.wikimedia.org/T310590 (10cmooney) >>! In T310590#8625183, @ayounsi wrote: >> The above may be overkill i think we could probably get away with less files e.g >> /srv/deployment/netbox/deploy/... [15:16:53] 10netbox, 10Infrastructure-Foundations, 10Patch-For-Review: Netbox: use Custom Model Validation - https://phabricator.wikimedia.org/T310590 (10jbond) >>! In T310590#8625183, @ayounsi wrote: >> The above may be overkill i think we could probably get away with less files e.g >> /srv/deployment/netbox/deploy/sr... [15:23:20] 10netops, 10Infrastructure-Foundations, 10ops-codfw: codfw: Bad power supply on cr1-codfw(PEM 0) - https://phabricator.wikimedia.org/T329943 (10Papaul) [15:32:45] 10netops, 10Infrastructure-Foundations, 10SRE, 10ops-codfw: codfw: Bad power supply on cr1-codfw(PEM 0) - https://phabricator.wikimedia.org/T329943 (10Papaul) Case Number 2023-0217-642078 Case Type Tech Priority P2 - High Status Dispatch [18:05:32] 10netops, 10Infrastructure-Foundations, 10SRE, 10ops-codfw: codfw: Bad power supply on cr1-codfw(PEM 0) - https://phabricator.wikimedia.org/T329943 (10Papaul) p:05Triage→03High [18:06:38] 10netops, 10Infrastructure-Foundations, 10SRE, 10ops-codfw: codfw: Bad power supply on cr1-codfw(PEM 0) - https://phabricator.wikimedia.org/T329943 (10Papaul) ***** RMA DETAILS ***** RMA Number: R200447858 Defective Line Item Number: 100 Defective Serial Number: Defective Product ID: MX480-PWR2520-AC-S Def... [21:10:05] 10netops, 10DBA, 10Data-Persistence, 10Infrastructure-Foundations, and 9 others: codfw row B switches upgrade - https://phabricator.wikimedia.org/T327991 (10colewhite)