[09:43:40] 10SRE-tools, 10Infrastructure-Foundations: Abstract a bit more the server provisioning process - https://phabricator.wikimedia.org/T351891 (10ayounsi) Wow, nice to see all the comments ! First this proposal is not about replacing the "ProvisionServerNetwork" Netbox script, so it makes sens to me to keep impro... [15:53:34] jbond: for puppet.git amend `tox.ini` with: `deps = commit-message-validator>=2.0.0` [15:53:34] ;) [15:53:49] I replied at https://phabricator.wikimedia.org/T265633#9356829 [15:54:17] hashar: ahh doh! thanks :) [15:54:27] and we can't update the docker image being used [15:54:35] cause the new one uses tox v4 and that breaks things :D [15:55:01] hashar: ack i think we will need to move this to bookworm / tox for soon so will have to takle that [15:56:50] hashar: im gussing ill ned to do another release of the docker image to pick up the tox changes? [15:57:33] not necessarily [15:57:57] if you send a patch in puppet.git which bump the minimum version of the commit message validator [15:58:09] then tox will simply upgrade the one built-in the image [15:58:40] hashar: but it will do that on every CI run right [15:58:43] yeah [15:59:00] then the image definition has tox v4 [15:59:06] ack yes so similar to changing the gemfile its fine but we should do a release to get them pulled in the image [15:59:21] so if we rebuild to add a new version of the validator and deploy, that also switch the job fro mtox 3 to 4 [15:59:31] ahh ok nuderstood [15:59:33] yeah same as gemfile :) [15:59:35] understood [15:59:42] I think the tox v4 is trivial for puppet [16:00:04] some of the rake task generated had to be adjusted to slightly change arguments passed to tox [16:00:06] yes i rember the issue [16:10:39] https://gerrit.wikimedia.org/r/c/operations/puppet/+/977223 rake: add support for tox v4 [16:10:41] that might be do it [16:11:10] which replaces the drive by commit made earlier in September ( https://gerrit.wikimedia.org/r/c/operations/puppet/+/954297 ) [16:11:24] jbond: we can do that on monday if we don't forget :] [16:12:46] thanks hashar i made a note to check it monday [16:12:54] \o/