[00:48:29] dfjgmxmdjnxnndmxm cjndnxnjxndnnxndnfn c. Cn. Jxnxnnxnndnfffrmd dhjrndjxnf dncncjcnnnndnrnnxdnxnxms c. Fjdndnmxnc dmdmdjxnbbfnmamsmxnxndkmwmmc ckbbdnnxmdmmdndmdndnmdmxfmfdnxjdnedneejenr cnxhndnxuhrduhyrm cnc fndkmdxjnrndnxnddjjdndndmdjdndndbcd [15:21:29] ahoyhoy. I need to deploy an update to php-wikidiff2 using debdeploy - could someone who knows debdeploy soundness check my manifest? https://phabricator.wikimedia.org/P17647 I'm unsure about the "source" field - is that the literal name of the deb package or of the source package? And is using wikidiff2 in the library field correct given the package installs a library to [15:21:35] /usr/lib/php/20170718/wikidiff2.so? [15:29:59] looking# [15:31:08] <_joe_> hnowlan: 2 things: 1 - check with legoktm how to recompile it for php 7.4 too, 2 - we will need to update the php images as well :) [15:31:16] the version should be 1.13.0-1, right? [15:31:33] the source is correct, it refers to the source package name [15:31:58] for wikidiff you don't really need a library field [15:32:16] this is mostly useful for general purpose libs like libssl which are used by multiple packages [15:32:50] but for wikidiff it's relatively straightforward since it's specific to PHP [15:33:31] actually, source: should be "wikidiff2" [15:33:47] php-wikidiff2 is just the binary package name [15:34:18] this specific package is extremely confusing since in the past we had a source package php-wikidiff2 [15:34:34] which only built hhvm-wikidiff2... [15:35:00] :D [15:35:33] PHP 7.4 should already have 1.13.0-1, I'll check the various images after meetings [15:36:02] I edited https://phabricator.wikimedia.org/P17647, the updated version should be good to go [15:36:23] you can also smoketest it with [15:36:57] debdeploy deploy -u 2021-11-01-wikidiff2.yaml -Q "P{mwdebug1001*}" [15:37:05] which only installs it on a single server [15:37:37] also, there's a helper generate-debdeploy-spec which interactively builds the spec file, not sure if you used that? [15:40:56] moritzm: yeah I did use it - thanks for all the details [15:41:02] _joe_: how are those builds triggered? [15:42:03] <_joe_> hnowlan: the docker images? just bumping the changelogs of the php images, but I can do that tomorrow or show you how to do it - I'm supposed to be off today :P [15:42:52] legoktm: I didn't build 1.13.0-1 for 7.4, I can do that now though (assuming it goes into the php74 component) [15:43:22] _joe_: cool, I'll have a look [15:43:22] <_joe_> but basically the only images where it's installed are the php-fpm7.{2,4}-multiversion-base [15:43:26] I just checked, it's already at 1.13 for PHP 74 [15:45:17] weird, how did that happen? I'm fairly certain I only built it for 7.2 [15:45:57] <_joe_> hnowlan: I guess legoktm built the php packages for 7.4 last week or so, so he picked up the right version from the start [15:46:11] ohhhh makes sense. [15:50:20] yep [17:41:55] hnowlan: fyi I took care of the image updates since I needed to upgrade PHP itself. For future reference, you need something like https://gerrit.wikimedia.org/r/plugins/gitiles/operations/docker-images/production-images/+/4de99a08bc2eb983f3aca798ff33fd22976c65e8 plus `sudo build-production-images` on deneb [17:42:55] legoktm: sweet, thank you [22:45:47] where is the varnish/ATS -> appserver (envoy) timeout defined? [22:50:58] legoktm: this? https://github.com/wikimedia/puppet/blob/765d39f66320a4def7adccaa8a63fc970e278eb0/hieradata/common/profile/trafficserver/backend.yaml#L388 which I found linked from https://wikitech.wikimedia.org/wiki/HTTP_timeouts [22:51:35] https://wikitech.wikimedia.org/wiki/HTTP_timeouts#Caching [22:52:16] * mutante gets a feeling you are asking to fix that "information is outdated" comment in that very page :p [22:54:03] mutante: hmm, thanks [22:54:08] 180s makes sense [22:54:29] but in MW on POST requests we have $wgRequestTimeLimit = 200 [22:55:14] which means that in some cases, MW is still trying to finish the request but varnish/ATS has already returned an error page [22:55:53] *nod* [22:58:32] I think https://phabricator.wikimedia.org/T250251 is the parent task for this [23:00:22] I feel like there is an ancient task that gwicke made for the same reason in the early restbase days. Which is mostly to say that this is a problem that has lingered for a long time. [23:01:49] I filed T294800 as a dedicated subtask for this specific issue [23:01:49] T294800: Reconcile MediaWiki POST timeout and Varnish/ATS timeouts - https://phabricator.wikimedia.org/T294800 [23:55:28] legoktm: thanks for looking at this, this is indeed a problem that has lingered for a long time