[10:55:24] <_joe_> moritzm: https://gerrit.wikimedia.org/r/c/operations/puppet/+/791582 or am I missing something? [10:55:51] looking [10:57:36] looks good. and the profile::docker::builder::rebuild_images and profile::docker:.reporter::generate_reports need to be flipped from deneb to build2001, that should be all AFAICS [10:58:26] <_joe_> yes [10:58:46] <_joe_> let me first test the whole build/publish workflow again [11:00:25] ack, sounds good [12:22:36] I'm trying to add new files for our install server config, covering new IP subnets allocated for cloud hosts [12:22:51] Getting an 'missing a SPDX licence header' error? https://integration.wikimedia.org/ci/job/operations-puppet-tests-buster-docker/44349/console [12:23:36] I'm sure it's something trivial I'm missing, fairly sure I'm doing it same way as last time. [12:28:12] topranks: try to run `bundle exec rake spdx:convert:new_files` in the root of your local puppet repo [12:28:53] ah ok thanks, I seen that but wasn't sure where to run it [12:29:22] see jbond's email about adding license to our repos [12:30:30] I'd missed that my bad. [12:30:32] thanks :) [12:31:20] yes i thought i would make fridays fun and merge today :) [12:31:30] topranks: let me know if you hit any issues [12:31:39] knew I should have just done this last night before I logged off :D [12:31:51] hehehe [12:31:55] cool, thanks John, working through it now, if I can't fix it I'll let you know. [12:32:21] ack [12:41:52] jbond: I'm struggling a little with this. The 'rake' command is failing for me, is that the best approach? [12:42:39] Reading your mail I can see there are non-wikimedia contributors, although many appear to be WMF staff just using non-wmf addresses [12:42:53] topranks: you can just manually add a comment to the top of the file(s) e.g. [12:42:54] perhaps volunteer contributions from staff like we discussed the other day [12:42:56] # SPDX-License-Identifier: Apache-2.0 [12:43:02] yeah that's what I was thinking [12:43:19] that will work will it? And is Apache 2 appropriate for the install-server module? [12:43:53] topranks: you should only need to add the header to new files (existing files shouldn;t trigger the CI error) [12:44:17] apache 2.0 is the licence to use for any wikimedia contributions [12:44:49] ok great, yep makes sense, we can tackle the legacy files another time probably [12:45:11] licencing non nwikimedia contributions is tricker see T308013 for a way forward and T67270 for some history [12:45:12] T308013: Assign SPDX headers to puppet.git - https://phabricator.wikimedia.org/T308013 [12:45:12] T67270: Default license for operations/puppet - https://phabricator.wikimedia.org/T67270 [12:45:19] yes exactly [12:45:43] in relation to take can yuo send me the error you got and are you mac/linux ? [12:45:49] s/take/rake/ [12:47:29] Linux.. yep. I tried from two different directories not being exactly sure: https://phabricator.wikimedia.org/P27825 [12:47:50] It may just be my system, I had to install a bunch of stuff to get that far may still me missing components or done something wrong [12:48:12] s/me/be/ [12:49:23] topranks: from the root of the dir you should be able to use `bundle install` [12:49:39] is the change in gerrit. the error is not what i expected [12:50:08] also you can get rid of those deprecation warnings with `RUBYOPT=-W0 bundle ...` [12:50:14] or just export RUBYOPT=-W0 [12:51:10] yeah the gerrit change is here: https://gerrit.wikimedia.org/r/c/operations/puppet/+/791595 [12:51:34] although I've just updated with new patchset adding the SPDX header to the new files, and Jenkins seems happy [12:51:44] previous patch set caused problem [12:52:10] ack thanks ill take a look [12:54:04] appreciate the help, let me know if there is anything else I can do to shed light on the rake problem [13:03:56] topranks: the reason you got *that* error is because your change was older then mine so when you had it checked out you didn;t have the new rake tasks. doing a `git rebase -i origin/production` brought in the new changes [13:06:17] topranks: try the following if that works then yuo should be good going foward [13:06:20] git-review -d 791601 ; RUBYOPT=-W0 bundle exec rake spdx:convert:new_files [13:25:33] jbond: thanks, I think it worked https://phabricator.wikimedia.org/P27826 [13:27:17] topranks: indeed that looks good [13:28:20] cool thanks! [13:29:09] np