[09:31:46] !log restart pybal on lvs5003 [09:31:50] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [09:32:00] sigh.. wrong channel.. good outcome [12:52:29] quick poll: do you find having to align => in puppet useful on balance? e.g. pro is increased readability and con is harder code reviews (again, for example, there's more cons IMHO than pros) [12:53:03] case in point right now for me is https://gerrit.wikimedia.org/r/c/operations/puppet/+/849088 where I definitely didn't have a good time [12:53:57] I think the lined-up looks nice, but agree it's a bit of a PITA (especially since I seem to always get it wrong first time) [12:54:20] godog: I think I'm for it. Sorry :-) [12:55:14] btullis: hehe no reason to be sorry, I'm mostly interested in what other folks think [12:55:36] Emperor: yeah editor support certainly has helped me, not perfect tho [12:55:52] godog: I find it very helpful for readability [12:59:35] thanks! so so far the answer seems a "yes" [13:05:21] IMHO it's helpful that all arguments are on the same indentation level, but CI failing because there's anything alignment other than "aligned at the longest argument +1" indeed fells like pointless toil (and https://gerrit.wikimedia.org/r/c/operations/puppet/+/849088 clearly shows why) [13:06:56] yeah that's a good point moritzm, a more relaxed check would be an improvement already [13:10:22] alternatively it'd be really nice if there would be some tool to automatically fix some lint violations instead of doing that manually [13:18:17] that too would be nice alright [13:55:08] this looks nice https://docs.python.org/3.11/whatsnew/3.11.html#pep-657-fine-grained-error-locations-in-tracebacks [13:56:59] oh niiiice [13:57:19] indeed [13:57:40] just wait those 2~3y before we get it in debian :-P [13:57:51] jokes apart, I'm not sure which version will in the end ship bookworm [13:57:56] currently at 3.10.6 [13:58:57] ref: https://wiki.debian.org/Python#Supported_Python_Versions [14:01:16] Bookworm will have 3.11, but the transition hasn't started yet since there are others currently ongoing [14:01:43] https://release.debian.org/transitions/html/python3.11-add.html [14:02:25] \o/ [14:21:15] godog: personally I'm in favor of it, I think that gerrit does a good enough job to highlight the bits that really changed, though I understand that would be easier to read without them at all yep [14:26:46] thx moritzm, good to know! [14:27:13] dcaro: indeed, there's actually an example in the review where I didn't have to shuffle parameters! https://gerrit.wikimedia.org/r/c/operations/puppet/+/849088/1/modules/arclamp/manifests/init.pp vs https://gerrit.wikimedia.org/r/c/operations/puppet/+/849088/1/modules/certspotter/manifests/init.pp [14:54:29] godog: i'm also a vote for yes. in theory there is `bundle exec rake lint_fix` in practice it needs some finessing to remove. that said you can manualy run puppet-lint maually [14:54:33] puppet-lint --no-wmf_styleguide-check --fix [14:59:04] jbond: neat, thanks I haven't run into lint_fix before! will give it a try [15:00:57] godog: for now you are better of just using puppet-lint manually ill take a look to see if we can get a saner lint_fix job which is more custom to our repo [15:02:24] ack! will do