[12:57:01] <brouberol>	 Hi everyone! I'm fishing for advice an opinions. In the last couple of mont
[12:58:07] <brouberol>	 *months, I've witnessed multiple investigations as to why a reimage process wasn't working as expected, which root cause was a subtle typo in `netboot.cfg` (missing semicolumn, missing `echo`, etc)
[12:59:21] <brouberol>	 I've opened a ticket to exemplify how we could generate this file from configuration (https://gerrit.wikimedia.org/r/c/operations/puppet/+/973308). I'm not sure that this is the way to go, or if this is something we'd like to have. As this is Friday, I took a stab at it, and am open to any suggestions. Thanks!
[13:03:26] <jbond>	 brouberol: nice genral idea looks good to me.  ill give it a proper review later 
[13:03:57] <brouberol>	 Thanks! Pardon my puppet, though
[13:09:30] <moritzm>	 I'll have a closer look next week. One note already: The new mechanism needs to maintain the exact order as the previous settings, this gets evaluated within the Debian installer and the first match "wins"
[13:13:31] <brouberol>	 as it stands right now, the configuration is defined in the exact same order as the initial file. I'll check that the generated file is in the same order as well
[13:14:47] <moritzm>	 ok
[13:20:29] <brouberol>	 moritzm it seems to be working well: https://phabricator.wikimedia.org/P53293
[13:21:45] <moritzm>	 nice! I'll check in more detail on Monday
[13:21:57] <brouberol>	 for sure, no rush, and thanks again
[13:56:11] <XioNoX>	 brouberol: that's awesome! thx
[13:57:06] <brouberol>	 My pleasure! 
[14:00:20] <denisse>	 brouberol: It looks pretty nice, thank you!
[14:02:29] <XioNoX>	 someone wants to give me an easy +1 ? https://gerrit.wikimedia.org/r/c/operations/puppet/+/973349
[14:03:04] <brouberol>	 done
[14:03:16] <denisse>	 Done.
[14:03:17] <XioNoX>	 <3
[15:03:31] <XioNoX>	 someone knows what the CI error on https://gerrit.wikimedia.org/r/c/operations/puppet/+/973350/ means?
[15:03:47] <XioNoX>	 is it related to my patch or something else in WMCS?
[15:04:40] <marostegui>	 XioNoX: I just sent a patch and I got the verified just fine
[15:05:29] <marostegui>	 XioNoX: I  guess this is from your patch? 07:00:31        error during compilation: Evaluation Error: Error while evaluating a Resource Statement, Ferm::Service[testservice1_11111]:
[15:05:29] <marostegui>	 07:00:31          parameter 'srange' variant 0 expects a String value, got Tuple
[15:06:51] <XioNoX>	 marostegui: yep I might have found the issue (trailing spaces after some IPs)
[15:10:17] <XioNoX>	 looks like that wasn't it
[15:11:43] <XioNoX>	 found it. " got 's620:0:861:12a::/64'" typo s/2