[01:10:39] <AntiComposite>	 the problem with mw-based /64-by-default is that there are some ISPs (usually cellular carriers) that assign smaller ranges
[15:38:47] <inductiveload>	 DannyS712, hi there :-D
[15:39:36] <inductiveload>	 re config for the PRP config option: were you thinking of a wgProofreadPage... global, or something more easily set on-wiki?
[15:42:02] <DannyS712>	 something like $wgProofreadPageAddTags defaulting to false and the being slowly enabled on a first wiki and then a few more and then everywhere
[15:42:27] <inductiveload>	 ok, so a global, can do
[15:43:01] <inductiveload>	 the other things were kind of an attempt at being "generic" but YAGNI, I guess
[16:10:31] <inductiveload>	 DannyS712, have you got any idea how to test this code?
[16:14:15] <DannyS712>	 patchdemo - https://patchdemo.wmflabs.org/
[16:29:45] <inductiveload>	 DannyS712, i meant more like "how do I write a test for this"
[16:30:25] <inductiveload>	 I have a local wiki install with docker working quite well
[16:36:39] <DannyS712>	 oh, integration test should have the feature enabled, make an edit and should trigger it, and then check that the correct tags were applied
[16:37:24] <inductiveload>	 do you know of a test that makes edits like that?
[16:37:51] <inductiveload>	 I'm struggling to find a suitable test to "be inspired by" (i.e. shamelessly steal from)
[16:41:10] <DannyS712>	 looking
[16:41:17] <inductiveload>	 ^_^ thanks
[16:45:56] <DannyS712>	 okay, drawing a bit based on https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/ProofreadPage/+/refs/heads/master/tests/phpunit/Page/PageContentTest.php#45 for how the content works, and using MediaWikiIntegrationTestCase::editPage
[16:45:56] <DannyS712>	 (https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/refs/heads/master/tests/phpunit/MediaWikiIntegrationTestCase.php#2333)
[16:48:49] <DannyS712>	 1) edit a page to have a content for a specific level
[16:48:49] <DannyS712>	 2) edit it again to have a content for a different level
[16:48:49] <DannyS712>	 3) use the returned Status object from the second edit, the value should be an array including a key 'revision-record' for the new edit you just saved
[16:48:49] <DannyS712>	 4) use RevisionStore::getRecentChange() with that revision record to get the relevant recent change
[16:48:49] <DannyS712>	 5) check that the recent change has the tags
[16:49:20] <DannyS712>	 *completely untested and I'm not entirely familiar with this extension
[16:49:52] <DannyS712>	 inductiveload hope this helps
[16:51:11] <inductiveload>	 sounds good, I'll give it a go
[16:51:33] <inductiveload>	 thanks for the tip, i've been a bit stuck!