[04:52:29] <AntiComposite>	 so...I broke Special:Preferences on Commons by adding lua to a gadget description template again... (self-reverted)
[04:54:59] <AntiComposite>	 apparently even something as simple as https://commons.wikimedia.org/wiki/Template:Str_right or https://commons.wikimedia.org/wiki/Template:Anchor will add 3-5 seconds to load time
[04:55:23] <AntiComposite>	 with both loading Special:Preferences took twice as long
[04:55:40] <AntiComposite>	 this is why we can't have nice things :)
[05:20:48] <Krinkle>	 AntiComposite: T65532, T51501
[05:20:49] <stashbot>	 T51501: Gadget preferences should indicate whether a gadget is enabled by default - https://phabricator.wikimedia.org/T51501
[05:20:49] <stashbot>	 T65532: Gadget preferences should hide or discourage entries that can't be enabled in the current skin (e.g. vector-only) - https://phabricator.wikimedia.org/T65532
[05:21:06] <Krinkle>	 We can improve the software instead in a more performant way :)
[05:21:18] <Krinkle>	 and have all wikis benefit
[05:21:55] <AntiComposite>	 yeah, planning on writing a patch tomorrow unless someone else beats me to it
[05:22:10] <AntiComposite>	 to add anchors to gadgets
[05:22:19] <Krinkle>	 awesome
[05:22:23] <Bsadowski1>	 anchors?
[05:22:24] <Krinkle>	 There's a task for that as well
[05:22:37] <AntiComposite>	 Bsadowski1, https://commons.wikimedia.org/wiki/Special:Preferences#mw-prefsection-gadgets-Gadget-QuickDelete
[05:23:27] <Krinkle>	 https://commons.wikimedia.org/w/index.php?search=anchor+ship&title=Special:MediaSearch&go=Go&type=image
[05:24:04] <Krinkle>	 I think the board vote banner font is getting bigger every day
[05:24:27] <Krinkle>	 either that, or I am leaning more forward to my screen. It now spans two lines even on my wider monitor.
[05:25:31] <AntiComposite>	 and more yellow
[05:27:11] <AntiComposite>	 aha https://meta.wikimedia.org/w/index.php?title=MediaWiki:Centralnotice-template-Election2021_Board_voting_starts_new&diff=21944385&oldid=21902872&diffmode=source
[05:31:47] <legoktm>	 Hmm, I don't think invoking LuaSandbox should be that slow
[05:32:05] <AntiComposite>	 https://performance.wikimedia.org/xhgui/run/view?id=6129b5b08a739f75809ad4b4
[05:32:30] <AntiComposite>	 it *shouldn't* be, but because Special:Preferences, it is.
[05:33:41] <AntiComposite>	 (for context this is after removing both {{anchor}} and {{str right}} https://performance.wikimedia.org/xhgui/run/view?id=6129be4c2a953433315393d4 )
[05:35:59] <legoktm>	 Oh, perfect. I think it's creating a fresh ScribuntoEngine for each message with a module? I'll look at the code when I'm back at my laptop
[05:37:07] <AntiComposite>	 https://phabricator.wikimedia.org/T278650 and the linked tasks are worth a read first
[05:42:27] * legoktm nods
[05:43:12] <legoktm>	 HSTSPreloadLookup is also showing up there because domains.php is pretty big.