[18:52:55] MatmaRex: ping if you're around :) looking at the OOUI issue, I think I found the issue, but would like to confirm intent/desire. [19:02:11] Krinkle: hi [19:02:36] Krinkle: i did not debug it, but i assumed that things are just happening in the wrong order now [19:06:56] MatmaRex: yeah, so it's kind of working as intended I think but I'd change ResourceLoaderOOUIFileModule instead. [19:07:09] MatmaRex: basically, when 'monobook' is set as 'skinStyles' on the module itself, [19:07:21] .. then a skin.json +moduleName is ignored, as it should be. [19:08:03] this previously worked because ResourceLoaderOOUIFileModule would set 'monobook' instead of '+monobook' but did so from the constructor as the last step. [19:08:06] probaby move the stuff from the constructor to a setSkinStylesOverride() override, right? [19:08:35] I was thinking for the last branch of extendSkinSpecific(), setting +monobook would work [19:08:38] but I'm wrong about that [19:08:44] oh, yeah, maybe it should be just + [19:08:46] because '+' isn't a skinStyles feature. [19:09:00] it only exists in the 'from skin.json inject' angle in setSkinStylesOverride [19:09:10] oh, right :D [19:09:13] so yeah, setSkinStylesOverride would be better, [19:09:14] thanks