[23:30:07] Amir1, urbanecm: I added https://wikitech.wikimedia.org/w/index.php?title=Add_a_wiki&type=revision&diff=1937783&oldid=1937648, is that good enough? or isn't there something that auto-generates patches now? [23:30:57] legoktm: there's https://github.com/Ladsgroup/Phabricator-maintenance-bot/blob/master/new_wikis_handler.py, but that only handles things outside of mediawiki-config repo [23:31:58] The plan is to add mediawiki config patches to the script once it's easier to create one. E.g. yaml config [23:32:03] got it [23:32:20] in any case, one more small step for some wikis [23:32:27] :/ [23:32:27] Currently it has to do replace is.php and that's a nogo [23:32:43] legoktm: what's the definition of "another non-standard domain name"? [23:33:11] well basically it has to match something in https://gerrit.wikimedia.org/g/operations/mediawiki-config/+/master/wmf-config/CommonSettings.php#218 [23:33:40] so e.g. wikifunctions.org would need to be added explicitly [23:33:46] got it [23:33:53] and do we add only SUL wikis? or all wikis? [23:34:22] the diff sounds to say only SUL wikis, but https://github.com/wikimedia/operations-mediawiki-config/blob/master/wmf-config/CommonSettings.php#L225 says "At a minimum, all SUL-linked wikis must be included here" [23:34:45] SUL wikis *need* to be in there, it would be nice to get all the other wikis in there but currently it makes no practical difference [23:35:33] and do not forsee any scenario in which we start making internal cross-wiki HTTP calls to non-SUL wikis [23:35:40] and I do not* [23:36:34] and if a SUL wiki is not there for whatever reason, what would i observe? other wikis being unable to make HTTP requests to it? or something else? [23:36:59] yes, and the most obvious user-facing part is that cross-wiki notifications won't load from that wiki [23:37:20] you'll see that you have an unread notification, but when you click to expand it, that'll fail [23:37:29] i see. thanks for the clarifications legoktm :) [23:37:49] :)) np [23:38:28] and if we for some reason removed commons and meta, then you'd start seeing GlobalUserPages and file description pages disappear [23:39:13] I'm sure there are other internal cross-wiki API requests I've forgotten about, but those are the most user-visible ones [23:40:05] i added a sentence explaining why the variable needs to be taken care of [23:40:23] :D perfect [23:59:22] By the way https://phabricator.wikimedia.org/p/BilalShirwani/ is mass vandalising tasks [23:59:29] eh [23:59:36] someone disabled it [23:59:37] Why are they still editing tasks while disabled [23:59:57] wtf [23:59:59] refresh the page