[00:52:46] Amir1: James_F: -17 modules TMH :) very nice https://grafana.wikimedia.org/d/BvWJlaDWk/startup-manifest-size?orgId=1&from=now-30d&to=now&var-wiki=commonswiki&var-component=TimedMediaHandler&var-multiwiki=commonswiki&var-multiwiki=dewiki&var-multiwiki=enwiki [00:54:46] excite [04:44:53] Awesome [13:54:00] [[Tech]]; Quiddity (WMF); /* Thank you letter from me and my former school for the outstanding browser compatibility. */ thanks; https://meta.wikimedia.org/w/index.php?diff=23356340&oldid=23354622&rcid=24158146 [13:56:40] [[Tech]]; Quiddity (WMF); /* Thank you letter from me and my former school for the outstanding browser compatibility. */ reply; https://meta.wikimedia.org/w/index.php?diff=23356346&oldid=23356340&rcid=24158179 [14:11:34] Krinkle: Nice! Do we have that in terms of bytes per page view so we can put it in the blog post? [14:12:16] James_F: we do, 1.0kb -> 389B (uncompressed) [14:12:24] Ah, nice. [14:12:31] Do we know what that'd be post-compressed? [14:12:47] not sure, but we might be able to get a sample from WebPageTest runs around that time before/after [14:12:50] But dropping 17 modules feels very nice, I must say. :-) [14:12:51] Ack. [14:24:31] Krinkle: Is there a way to see what the overall set of modules TMH puts out weigh collectively? https://grafana.wikimedia.org/d/Zx5m6iT7k/resourceloader-bundle-size?orgId=1&var-wiki=commonswiki&var-component=TimedMediaHandler&var-module=embedPlayerIframeStyle&from=now-90d&to=now is great but is always per-module, so it doesn't tell me what the pre-switch and post-switch page weights are. [14:26:55] James_F: when did we switch videojs for enwiki? [14:27:02] webpagetest will show pageweight [14:27:08] afaik Obama has a video on its article [14:27:35] we should see two drops, one for the tmh switch, and another this week for the ~1k startup shaving [14:30:58] Krinkle: For enwiki that was cfdd442e5 deployed 2022-05-02Z05:53 - https://sal.toolforge.org/log/WW9Ug4ABa_6PSCT9ogYs [14:34:50] https://grafana.wikimedia.org/d/000000057/webpagetest-drilldown?orgId=1&var-base=sitespeed_io&var-path=webpagetest&var-group=en_wikipedia_org&var-page=_wiki_Barack_Obama&var-browser=&var-location=us-east-chrome&var-connectivity=cable&var-view=firstView&from=1651464000000&to=1651507200000 suggests the JS went down from 296.29 to 289.82 KiB and HTML down ~700B, balanced out by the CSS going up 600B? [14:38:05] I'm currently distracted by a major 70KB increase two weeks prior https://grafana.wikimedia.org/d/000000057/webpagetest-drilldown?orgId=1&var-base=sitespeed_io&var-path=webpagetest&var-group=en_wikipedia_org&var-page=_wiki_Barack_Obama&var-browser=&var-location=us-east-firefox&var-connectivity=cable&var-view=firstView&from=1649911664588&to=1650008572606 [14:38:59] correlates exactly with the wmf.7 group2 deploy - https://www.mediawiki.org/wiki/MediaWiki_1.39/wmf.7 [14:38:59] Oh dear. Indeed. [14:39:03] but not seeing anything obvious there [14:40:10] it's a testament to our async load cycle that it dind't impact render times or PLT page load time [14:40:26] but also means we didn't get an alert and it's now beyond the date we keep detailed WPT logs for afaik [14:41:29] mw.inspect() on [[en:Obama]] says oojs-ui-core+widgets is loaded directly [14:41:33] that's suspect I suppose [14:44:18] mw.loader.findReady('oojs-ui-widgets') [ 0: Array [ "ext.uls.interface" ] [14:44:58] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UniversalLanguageSelector/+/716241 [14:55:43] Krinkle: Oh, fun. [14:56:43] Krinkle: But anyway, would it be fair to say that switching the video player "[shrank] the page payload for every page with a video on it by about 6.5 KiB"? [15:57:36] [[Tech]]; Nintendofan885; Tag unsigned message; https://meta.wikimedia.org/w/index.php?diff=23356680&oldid=23356346&rcid=24158996 [16:36:52] James_F: it appears that way, I'm surprised the difference isn't bigger, but I guess we already lazyload most of it. [16:37:29] I do note that it improved visual completion as well, not sure exactly why. https://grafana.wikimedia.org/d/000000057/webpagetest-drilldown?orgId=1&var-base=sitespeed_io&var-path=webpagetest&var-group=en_wikipedia_org&var-page=_wiki_Barack_Obama&var-browser=&var-location=us-east-firefox&var-connectivity=cable&var-view=firstView&from=1650554953933&to=1652019319150 [16:37:39] perhaps due to being similarly sized but more well-written JS code [16:37:59] less costly on rendering, taking away fewer resources from the rendering path. will try to confirm [16:39:26] Krinkle: Yeah, perhaps? The actual "amount of JS loaded when you interact to play the video" has dropped a lot, but that's not captured. [16:39:58] ack [20:52:13] related to the discussion about automatic translations in Discourse vs MediaWiki and privacy implications of using Google Translate (or other external providers) - https://blog.mozilla.org/en/mozilla/local-translation-add-on-project-bergamot/ came out today, fully local translations [20:52:39] that's cool [20:57:16] it's mostly webassembly, would be interesting if it could be wired into a gadget that lets you translate individual talk page comments or sections