[13:08:19] For a moment I thought we were about to lose our lovely mirror https://ftp.acc.umu.se/ but seems not after all https://mastodon.acc.umu.se/@pettter/108324052638068628 [13:51:09] Do we know how this site-specific cookie jars will work with SUL? https://blog.mozilla.org/en/products/firefox/firefox-rolls-out-total-cookie-protection-by-default-to-all-users-worldwide/ [13:57:40] Didn't we upstream something for that? [13:57:55] I seem to recall something in that area, but can't swear to it... Maybe just our ticket about it? [14:01:38] I couldn't find anything in Phabricator. There are multiple names being used for the various features though. [14:03:30] Hmm https://phabricator.wikimedia.org/maniphest/query/YhdvCpXOurrw/#R [14:04:31] Yeah [14:05:06] Maybe this is the task you had in mind https://phabricator.wikimedia.org/T255366 [14:34:09] maybe someone should ask the new CPTO [14:39:14] [[Tech]]; 58.145.184.242; [none]; https://meta.wikimedia.org/w/index.php?diff=23399246&oldid=23390565&rcid=24243313 [14:39:33] [[Tech]]; AntiCompositeNumber; Reverted changes by [[Special:Contributions/58.145.184.242|58.145.184.242]] ([[User talk:58.145.184.242|talk]]) to last version by Tacsipacsi; https://meta.wikimedia.org/w/index.php?diff=23399250&oldid=23399246&rcid=24243320 [14:41:14] [[Tech]]; 58.145.184.242; English; https://meta.wikimedia.org/w/index.php?diff=23399274&oldid=23399250&rcid=24243356 [14:41:32] [[Tech]]; AntiCompositeNumber; Reverted changes by [[Special:Contributions/58.145.184.242|58.145.184.242]] ([[User talk:58.145.184.242|talk]]) to last version by AntiCompositeNumber; https://meta.wikimedia.org/w/index.php?diff=23399282&oldid=23399274&rcid=24243371 [15:22:26] every time I see MediumSpecificBagOStuff, I have to remind myself why there isn't a VerySpecificBagOStuff or a RatherUnspecificBagOStuff... [15:31:58] And then a MaybeReturnVerySpecificBagOStuff, doMaybeReturnVerySpecificBagOStuff etc. [17:16:10] And ultimately the ReallyDoInternalBagOStuff [17:16:39] I guess nowadays we'd follow IBag and BaseBag as a pattern. [19:13:28] Is the way to take over a patch to git review it and then submit a new patch with similar code? [19:13:41] Thinking about https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/333684 which is long term inactive [19:13:49] and is a major merge conflict [19:15:01] My idea is to `git review -d 333684`, fix the merge conflicts and maybe change it a bit, and then submit a new patch? [19:30:03] Dreamy_Jazz: yes, feel free to take over someone else's patch when it's clearly abandoned like that [20:23:12] Dreamy_Jazz: in the end, the only part that controls which "change" it comes in at is the change ID line in the commit message. Sometimes its easier to start fresh from latest master and copy paste the commit message, or use the download/cherry pick option from the Gerrit interface instead of git-review -d. All ways are fine! [20:24:14] Thanks for the thoughts. Looking into re-writing this patch to work with the up to date code. [21:13:24] Does anyone know how to get the automated tests to run as a reviewer if they haven't been run? I'm trying to run the tests for https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/802469 but adding "recheck" didn't seem to get it to run (waited around 10 mins). [21:14:29] Dreamy_Jazz: they're just running still, see https://integration.wikimedia.org/zuul/ [21:15:57] Thanks. I think I was expecting to see "test coverage increased/decreased" which usually appears before the test results [21:16:23] But I presume I need to comment "check coverage" to get that to run [21:21:20] I get a 500 server error when loading https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/11562 [21:36:40] me too, probably worth a phab report in the #Gerrit project