[00:36:08] [[Tech]]; Mutante; /* enwiki database dump intervals */; https://meta.wikimedia.org/w/index.php?diff=23684972&oldid=23678797&rcid=24773420 [01:50:30] Krinkle, is there a reason that importScript being non-blocking and having a different return value wasn't communicated anywhere (ref https://phabricator.wikimedia.org/rMW51155b0dd6e8f98860a10bda96b982b6839110dc ) [01:50:39] it apparently is breaking some old stuff [01:51:47] https://en.wikipedia.org/wiki/User:MJL/Archer.js#L-1053 is the one I got a complaint about, but there'll be others [10:08:57] AntiComposite: thereis indeed lossing return value. However this has beennon blocking for many years already. Script tags in JS are always async. This script has been broken for a long time. The return value was previously the DOM element for the pending/not loaded, script tag. It broke now because it's undefinedinstead of an unrelated object. [10:09:52] Whatever it did wasn't using there return value. We can change it to templateAliases = {} and that would presumably do the same [13:04:40] [[Tech]]; L10nM4st3r; /* css element (continued) */; https://meta.wikimedia.org/w/index.php?diff=23686918&oldid=23685629&rcid=24776807 [14:25:17] [[Tech]]; AKlapper (WMF); [none]; https://meta.wikimedia.org/w/index.php?diff=23687164&oldid=23686918&rcid=24777838 [15:28:20] [[Tech]]; L10nM4st3r; [none]; https://meta.wikimedia.org/w/index.php?diff=23687396&oldid=23687164&rcid=24778347 [15:33:57] Does anyone know why the error 'Caused unexpected error!ApiUsageException: failed-save: The save has failed.' would be trigged in Wikibase by adding tests to CheckUser? [15:34:15] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/824746 fails because of this [15:35:01] I don't understand why changes to test files in CheckUser would cause issues with tests in another extension [15:35:23] As I thought phpunit tests don't affect each other (due to tearDown) [15:36:55] Extension dependancies exist [15:37:12] So other extensions can and will be loaded into MW when the tests for CheckUser will be running [15:38:43] Just confused why tests from another extension would fail due to changes in tests from another extension [15:39:04] And also because the new tests in CheckUser run fine [15:45:20] Do they fail repeatedly and reliably? [15:45:24] Could just be flaky tests [15:45:36] Yes [15:45:40] Did a recheck [15:48:33] And also another change I've submitted doesn't get the tests to fail [15:49:02] So it probably has to be something I've done, but I've no idea what [15:54:45] [[Tech]]; AKlapper (WMF); [none]; https://meta.wikimedia.org/w/index.php?diff=23687465&oldid=23687396&rcid=24778491 [16:15:03] [[Tech]]; L10nM4st3r; reply; https://meta.wikimedia.org/w/index.php?diff=23687577&oldid=23687465&rcid=24778658 [16:24:53] [[Tech]]; AKlapper (WMF); [none]; https://meta.wikimedia.org/w/index.php?diff=23687610&oldid=23687577&rcid=24778716 [18:44:01] [[Tech]]; L10nM4st3r; reply; https://meta.wikimedia.org/w/index.php?diff=23688183&oldid=23687610&rcid=24779798 [18:50:45] [[Tech]]; L10nM4st3r; /* css element (continued) */ reply, more specific; https://meta.wikimedia.org/w/index.php?diff=23688194&oldid=23688183&rcid=24779845 [18:53:18] [[Tech]]; L10nM4st3r; /* css element (continued) */ more; https://meta.wikimedia.org/w/index.php?diff=23688195&oldid=23688194&rcid=24779859