[02:09:30] [[Tech]]; 2409:4053:716:8DC5:1493:B8E4:9C2:FD33; /* New comer */ new section; https://meta.wikimedia.org/w/index.php?diff=23810587&oldid=23801273&rcid=24996558 [02:56:33] [[Tech]]; Novak Watchmen; Reverted changes by [[Special:Contributions/2409:4053:716:8DC5:1493:B8E4:9C2:FD33|2409:4053:716:8DC5:1493:B8E4:9C2:FD33]] ([[User talk:2409:4053:716:8DC5:1493:B8E4:9C2:FD33|talk]]) to last version by AKlapper (WMF); https://meta.wikimedia.org/w/index.php?diff=23810647&oldid=23810587&rcid=24996722 [17:10:27] In the namespace setting of The Bangla Wikipedia, can anyone give any reference to where the description of the namespace of a language that is not Bengali comes from in the InitialiseSettings.php? It's in lines ‌3309, 3310, 3312 and 3313. [17:11:36] MdsShakil: you can git clone the repo and run "git blame" on the file. Then in those lines you see which commit they are from.. and finally if you copy/paste that into gerrit.wikimedia.org you can see the message and linked ticket [17:12:50] i'll do that.. hold on [17:14:51] MdsShakil: looks like those got introduced in https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/535665 [17:15:04] "Migrate from InitialiseSettings to VariantSettings, a static array for testability" [17:15:44] or that's when they were touched last simply because of a refactoring [17:16:11] here is the diff: https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/535665/14/wmf-config/InitialiseSettings.php [17:20:34] mutante: Couldn't be sure where it was added from [17:20:58] It was before this change. [17:21:37] MdsShakil: yea, but I think you won't gain much from tracking it down further unless you are curious. because the fix will always be the same [17:21:52] assuming you mean it needs fixing [17:22:44] do you know how to submit a patch for code review? If so that would be the best option if you just suggest the change directly in code review [17:23:01] then we add James and others and you get email about it [17:23:40] mutante: Yes, I think it needs to be fixed. There is no need for this in Bengali Wikipedia. [17:25:13] MdsShakil: we can check the original ticket that asked for this to be created. either it had the values from the start or it's an accident later [17:25:51] but yea.. it kind of doesnt change the fix. maybe just focus on getting that deployed :) [17:26:26] optionally if you don't want to deal with code changes yourself, you can just report it like a bug in Phabricator [17:26:30] and someone else will fix it [17:26:42] mutante: Yes, I was looking for such a reference. [17:27:19] try searching for Bengale or "create Bengali" in https://phabricator.wikimedia.org/ if you want to find more history [17:27:59] you can also login with a Wikipedia user to have saved queries if you want [17:32:14] mutante: you can ignore revisions when doing a blame [17:32:26] Although not sure how it follows a file move [17:32:34] That's probably wouldn't work [17:45:49] mutante: https://phabricator.wikimedia.org/T318003 [17:46:38] MdsShakil: oh, very good! that looks good to me [17:47:04] MdsShakil: is it really not "replace with correct values"? is it really just "remove completely" ? or just wrong values [17:47:32] you tagged it with site-requests. that is good. it should mean people react to it soon [17:47:56] but keep in mind it needs a patch and then that needs to get in a deployment window first..a little patience is needed [17:48:11] thanks for reporting it as ticket [17:50:57] mutante: remove completely is the best idea, In Bengali we usually do not use aliases of these words. [17:51:39] ok, got it [17:52:22] ok, now just watch out for notifications from phabricator