[08:53:32] Hello everyone! I am trying to reach you here hoping you can help or address this issue: [08:53:52] I am facing errors Caught exception of type Flow\Exception\DataModelException when trying to start a new topic on mediawiki.org [08:57:41] known issue: https://phabricator.wikimedia.org/T338264 [09:35:42] Thanks, then I'll wait the fix to report another issue (extension SpamBlacklist: SMW 1.39.3 HTTP 500 - MWExceptionHandler on edit->submit) [09:36:40] it seems that after retrieving (and I assume execuring) the spam regex list throws an exception: [09:36:41] .. [09:36:41] [objectcache] fetchOrRegenerate(:pageimages-denylist): miss, new value computed [09:36:42] [objectcache] fetchOrRegenerate(:spamblacklist:spam:blacklist-regex): miss, new value computed [09:36:42] [SpamBlacklist] Loading spam regex... [09:36:43] [SpamBlacklist] Constructing spam blacklist [09:36:43] [DBConnection] Wikimedia\Rdbms\LoadBalancer::getLocalConnection: reused a connection for localAutoCommit/0 [09:36:44] [DBQuery] SqlBagOStuff::fetchBlobs [0s] localhost: SELECT keyname,value,exptime FROM `objectcache` WHERE keyname = 'global:blacklist_file_spam:https%3A//meta.wikimedia.org/w/index.php?title=Spam_blacklist&action=raw&sb_ver=1' AND (exptime >= '20230607074741') [09:36:44] [DBConnection] Wikimedia\Rdbms\LoadBalancer::getLocalConnection: reused a connection for localAutoCommit/0 [09:36:45] [DBQuery] SqlBagOStuff::fetchBlobs [0s] localhost: SELECT keyname,value,exptime FROM `objectcache` WHERE keyname = ':filewarning_spam:https%3A//meta.wikimedia.org/w/index.php?title=Spam_blacklist&action=raw&sb_ver=1' AND (exptime >= '20230607074741') [09:36:45] [SpamBlacklist] Loading spam blacklist from https://meta.wikimedia.org/w/index.php?title=Spam_blacklist&action=raw&sb_ver=1 [09:36:46] [http] GET: https://meta.wikimedia.org/w/index.php?title=Spam_blacklist&action=raw&sb_ver=1 [09:36:46] [exception] [4e67fd69d9fa28d9bf4cb940] /api.php PHP Fatal Error from line 49 of /var/www//includes/http/MWCallbackStream.php: Declaration of MWCallbackStream::write($string) must be compatible with Psr\Http\Message\StreamInterface::write(string $string): int [09:36:47] #0 [internal function]: MWExceptionHandler::handleFatalError() [09:36:47] #1 {main} [09:36:48] [session] Saving all sessions on shutdown [09:36:48] thank you. [09:37:43] michele_fella: hi, please use a paste bin next time for pasting long content. Thank you! [09:38:42] ok sorry. [19:04:26] can I get a removal on https://phabricator.wikimedia.org/p/KEMONO_PANTSU_KEMONO_PANTSU_KEMONO_PANTSU_KEMONO_PANTSU/ [19:07:57] i hate how the button on the 'please wait for a new 2fa token' screen is called 'wait patiently' [19:09:08] wonder what that is in pirate [19:09:28] is there an ?lang= for phab? [19:10:30] anyway, deleted the comments I could find [19:13:20] taavi: don't think there's any others [19:13:30] I've closed all the tasks he opened I wasn't beat too [19:13:38] And disabled the account via phab-ban [19:27:05] Hmm. Most of the comments happened after the account had already been locked on Meta. I guess that doesn't help if one has already logged in. [19:31:14] Nope [19:31:19] yeah, unfortunately locks don't kill the phab session [19:31:38] Unlike with ldap, disabling linked account doesn't invalidate anything [19:31:41] Maybe it should [20:18:41] RhinosF1: it could actually... we would basically just need to write the same kind of block/unblock hook handlers that are active for wikitech to fire when folks are blocked on mediawiki.org and/or globally. That might be worth a ticket and discussion. The code is a bit of work but mostly "easy" to put together. [20:22:38] bd808: the code is the easy bit [20:22:48] The discussion is the hard part [20:23:32] In this particular case the group to discuss the change is relatively small and technical I think, but I agree [20:25:29] bd808: it's wikimedia [20:31:30] https://phabricator.wikimedia.org/T338384 [20:33:58] thanks ACN [20:34:54] Ty AntiComposite [20:43:09] thanks for volunteering to do T338384 acn! [20:43:09] T338384: CentralAuth locks should logged linked users out of Phabricator - https://phabricator.wikimedia.org/T338384 [20:43:21] lmao [20:43:55] As I just posted, I think the only thing that needs working out is what the conduit (phab's api?) query for the attached account needs to be [20:44:35] Yes, in an ideal world, there's refactoring to do... [20:44:43] Reedy: https://phabricator.wikimedia.org/conduit/method/user.mediawikiquery/ [20:44:51] oh look at that, so simple ;P [20:45:21] * bd808 wrote both user.ldapquery and user.mediawikiquery back in the day for Striker [20:47:16] just chuck it in https://gerrit.wikimedia.org/g/operations/mediawiki-config/+/05b08d4c75e5d4a4ff83ead10506d5a6d91a3177/wmf-config/wikitech.php#131 somewhere? :D [20:48:00] presumably in some other file, as that's wikitech specific [20:48:55] yeah, that's what I was meaning about ideal world some refactoring [20:49:22] A quick glance at includes/Hooks/CentralAuthHookRunner.php doesn't suggest there's any existing hooks that are any use [20:49:27] T222209 would be nice to clean up in the process [20:49:29] T222209: Cleanup logging and curl use in wikitech post-block hooks - https://phabricator.wikimedia.org/T222209 [20:50:39] GlobalBlocking doesn't look to have any relevant hooks either... [20:50:52] So probably that needs sorting out first [20:50:54] https://phabricator.wikimedia.org/T196963 This was suggested a while ago for this hetre [20:51:17] here* [20:51:23] We're very good at thinking of ideas we've already thought of [20:51:34] ;) [20:51:48] But yeah, looks a 1:1 dupe [20:52:31] It's a dup that predates the known working fix though :) [20:52:37] "I dont think its expected that a global lock will kill your phab session." [20:52:43] heh :P [20:53:08] I'm glad we've improved things in 5 years [20:53:17] Better hooks? [20:53:20] :D [20:53:29] Nah, getting pissed off with vandals platform hopping :P [20:53:38] Bsadowski1: thats private [20:53:52] ? [20:53:53] "Globally blocked wiki accounts still have access to their Phabricator account" [20:54:08] oh [20:54:11] Reedy: do you want to write a patch to add a relevant hook to CA? :P I can also write one later [20:54:14] wtf [20:54:20] https://phabricator.wikimedia.org/T173463 is also a dupe [20:54:33] It probably doesn't need to be private... mostly a WP:BEANS type thing [20:54:48] I didn't quote anything that private :( [20:55:10] Bsadowski1: ye the task is but it doesn't need to be [20:55:23] Reedy: could it be just made public [20:55:35] So I got an error clicking the link [20:56:36] Oh I see, custom policy for some reason [20:57:01] Probably beans [20:57:25] yeah. just WP:BEANS nothing more worrysome [20:57:31] would https://phabricator.wikimedia.org/T338384 be considered beans in that case too? [20:57:36] ;) [20:58:09] * bd808 slaps Bsadowski1's hand as they try to stuff things in wrong places [20:58:13] lol [20:58:15] rip [20:58:48] there's also https://phabricator.wikimedia.org/T162996 [21:07:56] https://phabricator.wikimedia.org/T168692 and this :P [21:12:24] AntiComposite ^ [21:13:27] taavi: I probably won't get round to it tonight... I really need to go to bed "early", so I can get up "early" [21:13:42] "early"? [21:14:02] :D Is it actually early United States time [21:15:05] I don't live in US time :P [21:15:56] pfft, well, it's only 4 PM so that is early I suppose [21:33:56] Bsadowski1: Reedy only respects Swatch Internet Time