[15:09:39] FYI, Phabricator is temporarily down for https://phabricator.wikimedia.org/T333885 [15:10:44] Can someone add me to TrustedContributors on phab (whenever it comes up again) [15:11:12] (I want to make some edits on #proofreadpage but can't seem to be able to) [15:11:37] (Adding a editin-sequence column) [15:13:02] Sohom_Datta: what's your phab username? [15:13:18] @soda should be what I use [15:13:27] Cool [15:13:39] I will sort [15:13:51] Thank you :) [15:14:26] is it just me or did the phont change [15:17:21] It's using the default font now :( [15:17:38] (Which for me is monospace apparently) [15:17:52] AntiComposite: the phont did change yes [15:18:01] Sohom_Datta: done, enjoy extra buttons. [15:18:54] Thanks :) [21:41:59] what happenned to externallinks table? [21:43:42] Danny_B, 312666 ? [21:43:54] T312666 [21:43:55] T312666: Remove duplication in externallinks table - https://phabricator.wikimedia.org/T312666 [21:45:11] See also: https://lists.wikimedia.org/hyperkitty/list/cloud@lists.wikimedia.org/thread/KGTUOOI2BJDTSVCLHWGPNV4EYZUXCPFB/ [21:45:34] replicas on cloud have totally empty table even without columns [21:46:03] that sounds like outdated views... /me looks for open task [21:46:06] that seems like a problem :) [21:46:44] it worked two days ago [21:46:54] (to give you the timeframe) [21:46:56] T342683 [21:46:57] T342683: Stop writing to the old externallinks columns in beta cluster and production - https://phabricator.wikimedia.org/T342683 [21:47:14] yay, it's attached to the right place! [21:50:00] any eta when the table on replicas will be populated again? [21:50:36] ask on the task? :) [21:51:06] https://phabricator.wikimedia.org/T312666#8827670 says they should be exposed, but I think that Amir1 may have missed updating the actual views. Still looking for info on that. [21:54:08] err msg: view cswikinews_p.externallinks references invalid table(s) or columbn(s) or function(s) or definer/invoker of view lack rights to use them [21:54:49] maintain-views.yaml lists the externallinks table as a "fullview" which should mean that the view layer for it is functionally `select * from table` [21:57:48] just copying what i've read [21:57:56] Danny_B: yeah, at least on cswikinews_p a `show create view externallinks\G` shows enumerated columns and not the `*` I expected. This needs a bug report and running maintain-views across the replicas to fix I think. [21:58:40] cswikibooks the same. and i'm pretty sure it will be at least on all other wikis on the same cluster [21:59:04] please file the bug since you know more what exactly to write there [22:00:27] oh! I get what happens now. The `select *` is part of the create or replace command itself so it embeds the columns as they exist at the point in time that the script runs. [22:00:36] * bd808 writes up the bug [22:01:28] :joy: [22:01:49] bd808: pls add me to cc list, thx [22:06:42] I'm pretty sure that T343718 is the active task that is causing this failure. s5 and part of s3 are likely affected today. [22:06:43] T343718: Drop old columns of externallinks - https://phabricator.wikimedia.org/T343718 [23:01:55] Danny_B: at the moment, I think your externallinks queries will work again. They are possibly still broken on commonswiki_p, but I think I got the views updated everywhere else. More details on T344866 about the "at the moment" bit. [23:01:56] T344866: Queries to externallinks table fail following schema changes - https://phabricator.wikimedia.org/T344866 [23:07:36] bd808: unknown column 'el_index' in 'field_list' [23:08:00] Danny_B: ugh. which database? [23:08:08] cswikinews_p [23:08:13] let me try others [23:08:41] cswikibooks the same [23:08:44] cswikinews.analytics.db.svc.wikimedia.cloud works for me. [23:09:25] cswikinews.web.db.svc.wikimedia.cloud works for me as well... [23:12:48] Danny_B: is that error because your client is requesting externallinks.el_index? The new schema seems to be el_id, el_from, el_to_domain_index, el_to_path. [23:14:23] el_index and el_index_60 are columns that Amir1's changes are dropping [23:15:05] mw.o not updated :-/ [23:15:51] that is a different bug, but please do file it [23:24:37] sigh, so currently there is no way to get the domains / fullurls just from sql :-/ [23:27:54] Danny_B: I *think* you can recreate the full URL from el_to_domain_index and el_to_path. The tricky bit will be reversing el_to_domain_index in sql [23:30:22] bd808: exactly - the reversing is issue [23:40:08] till now it was also easy to filter results by omitting certain urls, now it will have to be coded externally due to the reversing