[18:10:19] <Dreamy_Jazz>	 Amir1: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/596088 breaks sending email confirmations on beta wikis
[18:11:04] <Amir1>	 😭 any stack trace?
[18:11:46] <Dreamy_Jazz>	 Yup
[18:12:26] <Dreamy_Jazz>	 [ZUkpXaHqWJf-gmDOlVpEkgAAAA0] /wiki/Special:ChangeEmail TypeError: Argument 4 passed to MediaWiki\Mail\Emailer::send() must be of the type string, array given, called in /srv/mediawiki/php-master/includes/user/User.php on line 3017
[18:12:26] <Dreamy_Jazz>	 Backtrace:
[18:12:26] <Dreamy_Jazz>	 from /srv/mediawiki/php-master/includes/mail/Emailer.php(43)
[18:12:26] <Dreamy_Jazz>	 #0 /srv/mediawiki/php-master/includes/user/User.php(3017): MediaWiki\Mail\Emailer->send(array, MailAddress, string, array, NULL, array)
[18:12:27] <Dreamy_Jazz>	 #1 /srv/mediawiki/php-master/includes/user/User.php(2984): MediaWiki\User\User->sendMail(string, array, NULL, NULL)
[18:12:27] <Dreamy_Jazz>	 #2 /srv/mediawiki/php-master/includes/user/User.php(1994): MediaWiki\User\User->sendConfirmationMail(string)
[18:12:28] <Dreamy_Jazz>	 #3 /srv/mediawiki/php-master/includes/specials/SpecialChangeEmail.php(196): MediaWiki\User\User->setEmailWithConfirmation(string)
[18:12:28] <Dreamy_Jazz>	 #4 /srv/mediawiki/php-master/includes/specials/SpecialChangeEmail.php(139): MediaWiki\Specials\SpecialChangeEmail->attemptChange(MediaWiki\User\User, string)
[18:12:28] <Dreamy_Jazz>	 #5 [internal function]: MediaWiki\Specials\SpecialChangeEmail->onSubmit(array, OOUIHTMLForm)
[18:12:29] <Dreamy_Jazz>	 #6 /srv/mediawiki/php-master/includes/htmlform/HTMLForm.php(751): call_user_func(array, array, OOUIHTMLForm)
[18:12:30] <Dreamy_Jazz>	 #7 /srv/mediawiki/php-master/includes/htmlform/HTMLForm.php(631): HTMLForm->trySubmit()
[18:12:30] <Dreamy_Jazz>	 #8 /srv/mediawiki/php-master/includes/htmlform/HTMLForm.php(647): HTMLForm->tryAuthorizedSubmit()
[18:12:31] <Dreamy_Jazz>	 #9 /srv/mediawiki/php-master/includes/specialpage/FormSpecialPage.php(231): HTMLForm->show()
[18:12:31] <Dreamy_Jazz>	 #10 /srv/mediawiki/php-master/includes/specials/SpecialChangeEmail.php(77): MediaWiki\SpecialPage\FormSpecialPage->execute(NULL)
[18:12:51] <taavi>	 are you saying that sending email from beta worked before? or that it's even more broken now?
[18:12:57] <Dreamy_Jazz>	 It worked before
[18:13:00] <Dreamy_Jazz>	 It is now broken
[18:13:19] <Dreamy_Jazz>	 I was recently able to confirm my email on beta wikis
[18:13:34] <Dreamy_Jazz>	 But doing this for a new account now fails with that error (some of the stack trace is cut-off due to flooding)
[18:14:15] <Dreamy_Jazz>	 Based on my understanding of the problem this would break confirming emails on all wikis if the train proceeds with this patch in it
[18:14:58] <Dreamy_Jazz>	 *all wikis with the newer wiki version
[18:17:31] <Amir1>	 I will make sure this is fixed before train hitting production but right now I'm dealing with another mess
[18:17:45] <Dreamy_Jazz>	 Okay. Do you want me to file a task and mark it as a train blocker?
[18:17:53] <Dreamy_Jazz>	 *and/or
[18:18:39] <Dreamy_Jazz>	 Would be useful for my sake to have a task as having a confirmed email address on beta wikis is needed to allow users to test a project I'm working on in Trust and Safety Product.
[18:20:56] <MatmaRex>	 yeah, please file a task
[18:21:04] <Dreamy_Jazz>	 Filing now.
[18:24:57] <Dreamy_Jazz>	 https://phabricator.wikimedia.org/T350614