[07:20:44] i found this piece of code: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/5ddf4037f273ff82532a890ea1f9827f78f65814/includes/deferred/LinksUpdate/LinksTable.php#465 [07:21:06] it appears to ignore errors when it's falsey, and the function is only used in unit tests [07:21:19] but why is it left to be null here? https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/5ddf4037f273ff82532a890ea1f9827f78f65814/includes/deferred/LinksUpdate/LinksTable.php#105 [07:21:37] shouldn't it be true so that errors are caught and (hopefully) logged in production? [08:50:48] [[Tech]]; 41.123.69.88; /* Denawoddalino..Dongawolidino..Ggonaddundiriri..Ddonganadiringi..Degonowalingi */ new section; https://meta.wikimedia.org/w/index.php?diff=28406681&oldid=28406582&rcid=34640585 [08:51:33] [[Tech]]; Aqurs1; [[Meta:Rollback|Reverted]] changes by [[Special:Contributions/41.123.69.88|41.123.69.88]] ([[User talk:41.123.69.88|talk]]) to last version by ArchiverBot: purely nonsense content; https://meta.wikimedia.org/w/index.php?diff=28406683&oldid=28406681&rcid=34640587