[21:32:05] Hi friends. [21:33:34] How long does it roughly take for gerritbot on phabricator to comment a change as per gerrit pushed review (change). Thanks [21:34:06] Why I ask? Just curious if I did it properly and if gerritbot is late to trigger. Not that I need it to, but it should've. So just curious. Thanks! :DDD [21:35:36] duude__: it's more or less instant [21:35:59] taavi: I see! Thanks taavi! :) [21:36:13] Any tips on figuring out where I messed up? :P [21:37:49] if you have a specific patch with a problem, it usually helps to link to it rather than leaving people to guess [21:40:22] taavi: Oh, sure! Thanks taavi. Pardon for not doing so. Wanted to RTM more, but that helps as well if you have more time! Thank you <3 [21:40:27] It's https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1200429 [21:41:59] I apologize if I did something wrong. I went through the wiki on multiple occasions. :) [21:53:26] Bug: needs to the last line before changeid iirc [21:53:48] Feature: isn't a thing [21:54:52] p858snake|cloud: thanks! [21:55:17] How would you tag a feature? Also as a bug? https://phabricator.wikimedia.org/T329670 [21:55:41] yes [21:56:18] (the trailer dates from the Bugzilla days where everything was called a bug) [21:57:17] you can have multiple Bug lines if its relevant to multiple phabricator tasks from memory [21:58:24] correct [22:00:03] Thank you nice folks! :)) Much appreciated! <3 [22:06:23] Okay. Amended commit message, and submitted patchset #2 for review. However I do notice now that it only tags the last mentioned bug. I suppose this is intended. What is the ideal solution? Thanks folks. [22:10:15] I hate that I'm needlesly cluttering it :( I wanted it to be perfect from the get-go. [22:14:37] Ha! CI fails. This is why I wanted to get local CI, lol. PHPUnit claimed it's all nice and fine. Brb. [22:15:26] Cursed JSON! D'oh! [22:15:42] Should've double checked :D [22:16:56] Ah.. And didn't check indentation. Ok that was indeed my bad :D Sheesh. [22:16:59] * duude__ shame. [22:17:04] brb gonna fix [22:17:16] this is fun i want to contribute more :D