[00:14:29] Wooo lets go. Finally I pass all tests :D Now to do extensive testing.. Sheesh. [11:05:50] duude__: good start \o/ [20:54:12] topranks: hiya :D is there a way to avoid containerlabs and the whole lab setup when testing locally? [20:54:26] I checked out templates but err yeah a lot of them rely on netbox or something else [20:55:44] e.g. asw role and such :D [20:58:52] tho ig I should ideally do labs. :3 [21:41:24] Oo.. I got it workin. Had to rewrite most of it solo lol [22:52:39] ah ok nice :) [22:53:33] sorry I've not had much time to check in with you [22:53:43] we can talk next week about how to get an environment working if you need [22:54:11] containerlab is not a requirement, but working JunOS devices of some kind is [23:05:38] topranks: thank you. i am just not 100% certain this code will work and I am a bit afraid to send CR :/ [23:06:06] don’t be afraid to send a CR [23:06:34] but we’ll have to fully test it one way or another [23:09:45] topranks: yeah.. i alr noticed I have e.g. netbox_data not thread-safe and that some of my error handling is sub-par and i also ended up copyig quite a lot of parallelization from itnernet and just experimenting and getting it to run.. barely.. passes pytests and formatting is on point, CI I see is not that advance to test it, since I mean it just test code formatting lol.. so I thought [23:09:47] about setting a full scale local testing env. but realized that would be quite complex if i truly wanted to test everything from netbox etc.. [23:10:03] and then I started looking more and more at code and I just keep realizing it really looks mashed together and I started to hate it [23:11:53] worst thing is I got the pool to properly run but hell even after RTM'ing it for 5th time I am still not 100% certain why e.g. ExecutionResult returns false success when it passes in debugging.. and then i changed logic and it magically works.. but its same thing [23:11:56] sheeeeesh [23:12:15] should've not done something this tricky tbh [23:12:20] feeling as if i just wasted time