[12:29:33] A_smart_kitten: I suspect it’s possible for a page ID to be skipped if the request that tries to create the page fails for some reason [12:30:11] in Wikibase it’s relatively common (though we’ve tried to rein it in) for item IDs to be skipped, because we “allocate” the item ID relatively early, and then the request may fail with constraints, rate limits, etc., at which point the ID has been “consumed” and will never be “returned” to the “available pool” so to speak [12:30:37] I think at least in principle something similar is possible even with an auto_increment database field, though probably not as common (assuming the insert happens quite late in the process) [12:32:19] the auto_increment ID has to be consumed immediately, even if the db transaction is rolled back; otherwise every subsequent insert would have to block until the translation commits [12:33:35] (and it’s just a single number, mariadb doesn’t keep track of “IDs that were temporarily blocked by now-rolled-back transactions but which are now free again”, they’re just skipped AFAIK) [12:34:27] I will let you know when I see mmyronov and I will deliver that message to them [12:34:27] @notify mmyronov I don’t think it’s possible to transfer the edit to your account; if you want to showcase it, I think you would just link it normally on your user page [12:34:41] thx wm-bot :3 [12:41:24] TIL about that functionality O.O [12:44:28] Lucas_WMDE: fair enough. in the flaggedrevs case i've been thinking about, I _suspect_ that something like that affecting this may be _unlikely_, as (IIUC) it'd require the `page_id` to be written to the `flaggedpages` table but *not* to the `page` table. i might be missing something though [12:47:42] (FWIW, it seems like there are 339 `page_id`s in dewiki's `flaggedpages` table that don't seem to appear in either the `page` table *or* the `archive` table... so who knows what's happened there ¯\_(ツ)_/¯ - https://quarry.wmcloud.org/query/103048) [14:05:23] please could someone with the right rights abandon https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/1251318 as a duplicate of https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/1251200? TIA :) [14:05:26] for context: https://meta.wikimedia.org/wiki/User_talk:A_smart_kitten#c-Codename_Noreste-20260313134000-Codename_Noreste-20260313133000 [14:06:32] sure [14:06:43] thanks taavi! [14:08:42] A_smart_kitten: yeah sounds like a different case then [14:31:06] patch 1251200 is tested as successful, do I schedule it for deployment immediately? [14:53:55] codenamenoreste: yeah, you can schedule it [14:54:10] (note that there are no deployments until Monday) [14:57:26] would that patch have to be approved first? [15:03:50] only if you were doing something unusual, but this seems like a routine config change to me, right? [15:04:34] ??????????? [15:08:04] that patch was about enabling the abusefilter block action for Portuguese Wikipedia [15:23:55] codenamenoreste: if you wanted, you could add someone familiar with AbuseFilter to take a look (https://www.mediawiki.org/wiki/Developers/Maintainers#MediaWiki_extensions_deployed_at_Wikimedia_Foundation lists a few possible folks). but for a number of more-routine config changes like this, deployers are often happy to perform the review themselves prior to deploying. [15:24:14] cc Lucas_WMDE who may have more accurate thoughts about this (as a deployer) [15:24:33] (^ the above should probably be suffixed with "in my experience") [15:25:29] when it comes to scheduling the patch, https://schedule-deployment.toolforge.org/ is a very useful tool IMO in case you weren't already aware of it :) [15:29:11] on a different matter -- taavi thx for correcting my tagging mistake on T420011 :) do you know which tag might be the 'right' one for tasks about rate-limits that come from operations/deployment-charts? only asking as I feel Phab may end up seeing a few more of those sorts of tasks in the relatively near future, and it'd be nice to know who/where to direct them to. [15:29:12] T420011: Intermittent rate limiting at hackathon-northwestern-europe-2026 - https://phabricator.wikimedia.org/T420011 [15:29:26] a few random ideas: mw-platform-team? mw-interfaces-team? serviceops? bot-traffic-requests? [15:30:54] A_smart_kitten I'm already familiar with abuse filters [15:31:56] codenamenoreste: I meant in terms of reviewing / +1ing the patch (apologies if I could have been clearer!) [15:32:46] Anoop already added a +1 to my patch [15:35:31] A_smart_kitten: my understanding is platform but that might also be not at all correct [15:53:58] A_smart_kitten: one other thing I would check is whether past changes in that area have required any special review [15:54:13] conveniently this one is in its own file so I can just use the gitiles file log https://gerrit.wikimedia.org/r/plugins/gitiles/operations/mediawiki-config/+log/refs/changes/00/1251200/3/wmf-config/abusefilter.php [15:54:45] and https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/1235134 https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/1223155 look like no special approval is needed, so I agree, should be fine to deploy