[10:26:29] James_F: I caught the bug! It's a tricky one: [10:26:29] The fix is here: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLambda/+/868787/7..8/resources/ext.wikilambda.edit/components/function/editor/FunctionEditorInputsItem.vue [10:26:30] Having a debounce linked to a global variable for all the components had side effects on selenium tests. Now that the variable is a property of the component, it should be better. [10:26:51] (The bug about the first field label in function definition being cleared) [13:49:50] While writing the E2E tests, I got this bug: https://phabricator.wikimedia.org/T329371 [14:41:22] kindrobot: I think it's ready for review, all the E2E tests pass with the wanted changes! [14:41:22] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLambda/+/868787 [14:42:07] Also I had to fix 2 stuffs in the code (a bug and a performance issue) [15:09:25] Hello! Mahfuza here. [15:09:26] I would like to contribute on Wikipedia abstract regarding this task -https://phabricator.wikimedia.org/T328587. Will you please guide me from which task should I start? I have checked all the links shared in phabricator. [17:28:11] Hey mhmohona are you specifically interested in getting involved for GSoC or just to get involved in general? [17:28:44] I am interested in getting involved for GSoC. [19:32:02] mhmohona: You could pick any of the linked micro-tasks in that ticket or any task with the tag good-first-task https://phabricator.wikimedia.org/project/board/4876/?filter=BVP6iAWQGwbL [19:33:43] James_F: with regard to the conversation in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLambda/+/868787, to merge this patch and not break our Beta Cluster tests... is there an establish practice? I imagine teams have selenium tests that require them to log in. Do they create a new account on every run, skip those tests in beta cluster, or something else? [20:43:22] kindrobot: The normal practice is to run these jobs from Jenkins which injects the MEDIAWIKI_USER / MEDIAWIKI_PASSWORD variables into the job from its credentials store (see https://gerrit.wikimedia.org/r/plugins/gitiles/integration/config/+/refs/heads/master/jjb/job-templates.yaml#1042 for the template). But for these we want to be new-world GitLab not old-world legacy CI; can we fetch them from GitLab somewhere? (Not sure if [20:43:22] there's such a thing in GitLab.) [20:44:47] You mean have the beta cluster jenkins run fetch it from GitLab somehow? [20:45:33] Oh, are you triggering this from the Jenkins installed for legacy CI? In that case, just inject it from there? [20:46:38] But how would https://aw-gerrit-gitlab-bridge.toolforge.org/ trigger Jenkins to trigger the job? [20:49:59] * I think we have our wires crossed. :) We can and will run these test in GitLab, and there is a secure storage for environment variables that can be passed into jobs. For Jenkins/beta cluster, I was thinking we'd set up a user and inject the credentials through an environment varialbe. It seems the way to do that is through the credential store, yeah? [20:50:19] Yes. [20:50:40] OK, great. I can look into that. :D [20:50:49] Thank you! [20:51:02] :-) [20:51:04] Sorry! [22:14:07] Hey florent are you interested in coming to a short talk I'm giving next Tuesday at 5p UTC about the kubernetes e2e setup?