[01:23:38] Does the page https://www.wikifunctions.org/wiki/Wikifunctions:Embedded_function_calls/sandbox work for anyone? It was linked from the weekly summary. I only see "Function is being called..." several times there. [06:09:40] It worked for me yesterday when I made the last edit to it, but now I see the same as you. (re @amire80: Does the page https://www.wikifunctions.org/wiki/Wikifunctions:Embedded_function_calls/sandbox work for anyone? It was linked fr...) [07:25:27] The page itself now seems okay, but I still see the messages instead when I just follow the link šŸ¤” …testing https://www.wikifunctions.org/wiki/Wikifunctions:Embedded_function_calls/sandbox (re @amire80: Does the page https://www.wikifunctions.org/wiki/Wikifunctions:Embedded_function_calls/sandbox work for anyone? It was linked fr...) [11:01:09] Initially, the ā€œFunction is being calledā€¦ā€ placeholders remained, but these have now cleared themselves. (re @Al: The page itself now seems okay, but I still see the messages instead when I just follow the link šŸ¤” …testing https://www.wikifunc...) [11:42:40] I’ve added and connected Z28669. If we want to trap index-out-of-range errors, we can add that to the helper function. We’re still untyping some types of list that we don’t need to, notably for type Z6001, but the performance benefits fade quite quickly with each additional type tested, so I thought I’d add a test case before extending the exception types. In an appropria [11:42:40] [11:42:41] te context, we can just call Z28661 directly, of course. (re @u99of9: Al do you think we can speed up Z13397 by splitting the behaviour for types that do/don't serialise?) [11:43:32] I probably meant Z6003 šŸ¤” (re @wikilinksbot: Z28669 – nth element, Composition calling helper [11:43:32] Z6001 – Wikidata item [11:43:34] Z28661 – element by index (helper)) [12:11:30] Sounds good, thanks. (re @Al: I’ve added and connected Z28669. If we want to trap index-out-of-range errors, we can add that to the helper function. We’re sti...) [12:15:12] did you purge the cache? (re @amire80: Does the page https://www.wikifunctions.org/wiki/Wikifunctions:Embedded_function_calls/sandbox work for anyone? It was linked fr...) [12:15:32] https://tools-static.wmflabs.org/bridgebot/61201c65/file_74192.jpg [12:15:49] after purging page cache I got that [12:17:38] I did, some hours later… that fixed the problem fairly quickly, but not when following the link from here. (re @Npriskorn: did you purge the cache?) [12:18:40] I got this menu from somewhere, dont remember [12:18:45] https://tools-static.wmflabs.org/bridgebot/79af1ecc/file_74193.jpg [12:40:20] I've been toying around a bit with Wikifunctions most recent dump. I made a graph of how functions rely on one another via compositions: https://commons.wikimedia.org/wiki/File:Wikifunctions_ZID_composition_graph.png [12:44:28] Yes, the Content error comes from calling the function with a Wikidata item reference rather than an instance of Chemical element. Why functions taking a lightweight enum instance as an argument are not available as embedded functions is unclear, but creating a generic component is not obviously covered by *T390558*. (re @Npriskorn: after purging page cache I got that) [12:45:28] Yes, that still shows the issue. The content error is because it can't read in the qid as an enum instance. (re @Npriskorn: after purging page cache I got that) [12:54:47] Thinking about it, I don’t think we can currently convert a QID into an enum instance, even given the enum’s ZID or Z9 šŸ¤” (re @u99of9: Yes, that still shows the issue. The content error is because it can't read in the qid as an enum instance.) [12:56:38] You mean because we also need to specify the type we are turning it into? (re @Al: Thinking about it, I don’t think we can currently convert a QID into an enum instance, even given the enum’s ZID or Z9 šŸ¤”) [12:57:29] Z26779? (re @Al: Thinking about it, I don’t think we can currently convert a QID into an enum instance, even given the enum’s ZID or Z9 šŸ¤”) [13:03:41] Yeah, because we can’t read a Type from a string. I’ll have a think. (re @u99of9: You mean because we also need to specify the type we are turning it into?) [13:05:40] I was hoping the type created by the enum function would have a read function in it that would already know what type it was instanciating. (re @Al: Yeah, because we can’t read a Type from a string. I’ll have a think.) [13:11:01] Just like I was hoping it would have an equality function. (re @u99of9: I was hoping the type created by the enum function would have a read function in it that would already know what type it was ins...) [13:11:31] Makes sense. But it doesn’t. It has a ZID-string, which is the necessary information, but we need both that ZID and the WID to make an enum instance… I think. (re @u99of9: I was hoping the type created by the enum function would have a read function in it that would already know what type it was ins...) [13:12:25] WID? [13:18:27] QID/PID/LID etc, any Wikidata reference. (re @u99of9: WID = QID?) [13:21:39] Is your objective to somehow avoid the need for a read function? IMO we need to ask David for one, because otherwise I can't see how embedded calls to functions with enum inputs can ever work. (re @Al: Makes sense. But it doesn’t. It has a ZID-string, which is the necessary information, but we need both that ZID and the WID to m...) [13:28:42] I think we need a (enum) type-aware component for the embedded function editor. For a Wikitext #function call, that has to resolve to ZID+WID, doesn’t it? (re @u99of9: Is your objective to somehow avoid the need for a read function? IMO we need to ask David for one, because otherwise I can't see...) [13:34:05] I don't use any embedded function editor, I just type Wikitext #function. I think there is enough info in the call: {{#function:Z27962|Q1115}} because the function called has a clear required input type. [13:34:13] I don't use any embedded function editor, I just type Wikitext #function. [13:36:58] In general, any item could feature in any number of enumerations. (re @u99of9: I don't use any embedded function editor, I just type Wikitext #function. I think there is enough info in the call: {{#function:...) [13:39:17] Yes. But it can infer that it needs to be Z27951 because that's what Z27962 requires? [13:40:16] Fair point šŸ˜ (re @u99of9: Yes. But it can infer that it needs to be Z27951 because that's what Z27962 requires?)