|
2026-01-02 19:15:28
|
<Reedy>
|
Anyone fancy chancing merging https://gerrit.wikimedia.org/r/c/mediawiki/vendor/+/1221974 and I guess https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1221975 for the moment...
|
|
2026-01-02 19:56:38
|
<zabe>
|
sure
|
|
2026-01-02 22:56:11
|
<A_smart_kitten>
|
Reedy: this is probably a relatively minor point (although in any event probably good to clarify understandings), but should tasks for PHP 8.4/8.5 CI failures be tagged with the WMF-deployed build failure Phab project?
|
|
2026-01-02 22:56:28
|
<A_smart_kitten>
|
just asking the understanding that i'd personally picked up over time was that the 'WMF build failure' project was for CI errors that were blocking the merging of patches in WMF-deployed repos / that were in the main/gate-and-submit tests.
|
|
2026-01-02 22:56:30
|
<A_smart_kitten>
|
it's very possible that i have a mistaken understanding, though :)
|
|
2026-01-02 22:56:31
|
<Reedy>
|
TBH, it's very unclear
|
|
2026-01-02 22:56:42
|
<Reedy>
|
For me, if it is stuff we deploy to WMF... yes
|
|
2026-01-02 23:00:12
|
<Reedy>
|
https://phabricator.wikimedia.org/project/view/4742/
|
|
2026-01-02 23:00:18
|
<Reedy>
|
>This tag is used to track issues with Jenkins jobs (in the test or gate pipeline of Zuul, or post-merge in Travis CI) that are failing due to the master branch of a WMF-deployed repository having reached a state that is not consistently passing its own tests.
|
|
2026-01-02 23:06:39
|
<Reedy>
|
A_smart_kitten: and more specifically...
|
|
2026-01-02 23:06:40
|
<Reedy>
|
>MediaWiki core tests failing on Travis CI for PHP versions, or database backends, not yet covered by our Jenkins jobs.
|
|
2026-01-02 23:06:56
|
<Reedy>
|
I guess that travis comment is irrelevant now (let me fix it)
|
|
2026-01-02 23:09:02
|
<A_smart_kitten>
|
I was gonna say, I assume it at least predates when I got more actively involved in wikimedia dev stuff :)
|
|
2026-01-02 23:11:05
|
<Reedy>
|
It's been a few years since travis swapped for github actions on many repos
|
|
2026-01-02 23:12:13
|
<A_smart_kitten>
|
anyhow, fair fair, that example in the Phab project description clears up the scope for me then :) mostly i just wanted to make sure i was working off the same understanding as everyone else about it
|
|
2026-01-02 23:18:21
|
<A_smart_kitten>
|
the only other thing that occured to me was in case anyone wanted to track how often CI errors blocked merges in a Wikimedia-deployed repo (and wanted to use the wmf-build-failure project to do that)
|
|
2026-01-02 23:19:53
|
<Reedy>
|
AFAIK we haven't tried to model that...
|
|
2026-01-02 23:20:23
|
<Reedy>
|
measure
|
|
2026-01-02 23:34:49
|
<A_smart_kitten>
|
fair enough
|
|
2026-01-04 06:53:15
|
<Krinkle>
|
Reedy: I removed "MediaWiki core tests failing on PHP versions [..] not yet covered [..] (for example our `experimental` jobs)." because those would not be high priority to unbreak (and aren't regressions). The Travis version of that bullet point was about PHP versions that we supported and were passing but couldn't be run in Jenkins for technical reasons (eg missing packages or base images).
|
|
2026-01-04 06:54:49
|
<Krinkle>
|
we track them under the PHP X.Y tags and umbrella tasks as well which seems a lot/enough. Happy to change if you think that'd be useful but afaik we haven't used it for that in recent history, and before then we didn't either for experimental / never-before-passing issues.
|
|
2026-01-04 19:20:43
|
<A_smart_kitten>
|
^ acknowledged re the scope of the wmf-deployed build failure project (in which case i guess the tasks at https://phabricator.wikimedia.org/maniphest/query/AaXo_XYy8dP0/#R should maybe be [silently] batch-edited to add `#ci-test-error` & remove `#ci-test-error (WMF-deployed Build Failure)`?)
|
|
2026-01-05 14:43:32
|
<Lucas_WMDE>
|
ori: looking at https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1220661/2/includes/Config/SiteConfiguration.php, I wonder if you’d be interested in benchmarking array_key_exists() vs. \array_key_exists()?
|
|
2026-01-05 14:43:46
|
<Lucas_WMDE>
|
(I’m guessing that you already have a good setup to benchmark MW whereas I don’t ^^)
|
|
2026-01-05 14:44:30
|
<Reedy>
|
It would be good to have a policy on that and/or having use statements for these global functions...
|
|
2026-01-05 14:44:52
|
<Reedy>
|
Didn't Tim have a benchmark for this at one point?
|
|
2026-01-05 14:44:54
|
<Lucas_WMDE>
|
yeah I’ve been wondering about that in the back of my head for a while, but performance numbers on it would be a much better argument
|
|
2026-01-05 14:48:04
|
<Lucas_WMDE>
|
(for reference, https://github.com/php/php-src/commit/f5044a12dd and https://github.com/php/php-src/commit/0bbfebb6d9, via https://github.com/php/php-src/pull/3360, are the optimizations that could benefit from knowing that array_key_exists() isn’t a function in MediaWiki\Config\ or MediaWiki\)
|
|
2026-01-05 14:49:24
|
<Lucas_WMDE>
|
Reedy: I can’t find anything on Phabricator at least (but it doesn’t help with the search that “namespace” is a very overloaded word)
|
|
2026-01-05 14:49:42
|
<Reedy>
|
I can't remember if it was in a library...
|
|
2026-01-05 14:49:51
|
<Reedy>
|
Similarly searching for global functions isn't helpful either :D
|
|
2026-01-05 14:53:56
|
<taavi>
|
do we still sometimes load it from a symfony polyfill or is that old enough to be in all the versions we support?
|
|
2026-01-05 14:54:47
|
<Reedy>
|
array_key_exists
|
|
2026-01-05 14:54:47
|
<Reedy>
|
(PHP 4 >= 4.0.7, PHP 5, PHP 7, PHP 8)
|
|
2026-01-05 16:49:51
|
<ori>
|
Lucas_WMDE: that's so interesting, thanks for flagging it! Busy week at work but I'll try to benchmark it in the next couple of days. Please poke me if you don't hear back.
|