|
2026-04-17 10:57:38
|
<A_smart_kitten>
|
hello, i have a favour to ask for someone with MediaWiki shell access (if possible) -- if you're comfortable with doing so, please could you check the effective value of the `$wgFlaggedRevsHandleIncludes` on `enwikinews`?
|
|
2026-04-17 10:58:42
|
<A_smart_kitten>
|
the context is https://phabricator.wikimedia.org/T423512#11827347 & https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/1271839 -- I'm not sure, but - given that other overrides for `$wgFlaggedRevsHandleIncludes` seem to be set in InitialiseSettings rather than flaggedrevs.php, I wonder if the IS.php default for that config variable might be overriding the custom value set for it in flaggedrevs.php
|
|
2026-04-17 12:00:14
|
<Lucas_WMDE>
|
A_smart_kitten: it seems to be 2
|
|
2026-04-17 12:00:23
|
<Lucas_WMDE>
|
(`mw-debug-repl enwikinews` on deploy1003)
|
|
2026-04-17 12:01:25
|
<Lucas_WMDE>
|
so IIUC, I think you’re correct that https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/1271839 has no effect
|
|
2026-04-17 12:01:45
|
<Lucas_WMDE>
|
*insert obligatory bash quip about FlaggedRevs here*
|
|
2026-04-17 12:03:06
|
<Lucas_WMDE>
|
hm, though the headers of IS.php and CS.php seem to say that IS.php is loaded before CS.php?
|
|
2026-04-17 12:03:10
|
<Lucas_WMDE>
|
*confused*
|
|
2026-04-17 12:04:01
|
<A_smart_kitten>
|
Lucas_WMDE: yeah, i also wondered about something like that since posting here, but for a different reason -- FWICS, that flaggedrevs.php config setting is set within a MediaWikiServices hook handler
|
|
2026-04-17 12:04:11
|
<A_smart_kitten>
|
but,,, if that's what a prod shell is saying...
|
|
2026-04-17 12:04:29
|
<A_smart_kitten>
|
also, thank you for checking that out!!
|
|
2026-04-17 12:05:05
|
<Lucas_WMDE>
|
I added a call to load MediaWikiServices just to be sure, but $wgFlaggedRevsHandleIncludes is still 2 afterwards
|
|
2026-04-17 12:05:10
|
<Lucas_WMDE>
|
so no idea why that code is behaving weirdly
|
|
2026-04-17 12:05:30
|
<Lucas_WMDE>
|
I guess I could try moving the assignment to IS.php in mw-experimental
|
|
2026-04-17 12:05:36
|
<A_smart_kitten>
|
Lucas_WMDEfor the obligatory bash quip, both the ones at https://bash.toolforge.org/search?q=flaggedrevs seem to fit :p
|
|
2026-04-17 12:05:52
|
<Lucas_WMDE>
|
yeah :P
|
|
2026-04-17 12:06:16
|
<A_smart_kitten>
|
Lucas_WMDE: i'm not gonna say you have to do that (it's up to you), but i am also now _insanely_ curious regarding whether that would do anything :p
|
|
2026-04-17 12:06:43
|
<Lucas_WMDE>
|
flaggedrevs https://wikis.world/@LucasWerkmeister/116262429520403607
|
|
2026-04-17 12:09:37
|
<Lucas_WMDE>
|
bah, I forgot how tedious it is to run a shell script in there
|
|
2026-04-17 12:09:40
|
<Lucas_WMDE>
|
looks up the right task
|
|
2026-04-17 12:11:18
|
<Lucas_WMDE>
|
hm. still says the value is 2
|
|
2026-04-17 12:11:25
|
<A_smart_kitten>
|
huuh
|
|
2026-04-17 12:11:43
|
<Lucas_WMDE>
|
bnwiki is 0 though
|
|
2026-04-17 12:11:49
|
<Lucas_WMDE>
|
so at least some of the IS.php overrides work
|
|
2026-04-17 12:12:14
|
<Lucas_WMDE>
|
oh
|
|
2026-04-17 12:12:19
|
<Lucas_WMDE>
|
it helps if I use the same dbname everywhere
|
|
2026-04-17 12:12:29
|
<A_smart_kitten>
|
;p
|
|
2026-04-17 12:12:40
|
<Lucas_WMDE>
|
yeah ok with enwiki*news* instead of -source it does return 0
|
|
2026-04-17 12:12:48
|
<Lucas_WMDE>
|
so yeah, move the config override to IS.php
|
|
2026-04-17 12:12:54
|
<Lucas_WMDE>
|
do you want to comment on the task or should I? ^^
|
|
2026-04-17 12:13:25
|
<Lucas_WMDE>
|
(I came so close to reenacting https://bash.toolforge.org/quip/AU7VT58p6snAnmqnK_qP!)
|
|
2026-04-17 12:13:35
|
<Lucas_WMDE>
|
(or https://bash.toolforge.org/quip/Sj3KapEBKFqumxvtIHYX)
|
|
2026-04-17 12:13:38
|
<A_smart_kitten>
|
i was about to say "will do, i'll comment on that patch/task", but i kinda think you might actually do a better job than me of explaining what you've found
|
|
2026-04-17 12:13:54
|
<A_smart_kitten>
|
i can get a patch up, though
|
|
2026-04-17 12:13:55
|
<Lucas_WMDE>
|
ok, then I can paste terminal output there
|
|
2026-04-17 12:13:58
|
<Lucas_WMDE>
|
sounds good
|
|
2026-04-17 12:17:31
|
<Lucas_WMDE>
|
A_smart_kitten: commented
|
|
2026-04-17 12:19:13
|
<A_smart_kitten>
|
Lucas_WMDE: apologies if i'm missing something, did you meant to copy the bnwiki result?
|
|
2026-04-17 12:19:51
|
<Lucas_WMDE>
|
uh
|
|
2026-04-17 12:19:53
|
<Lucas_WMDE>
|
did I copy the wrong black
|
|
2026-04-17 12:19:55
|
<Lucas_WMDE>
|
*block
|
|
2026-04-17 12:19:58
|
<Lucas_WMDE>
|
has already closed the wrong terminal
|
|
2026-04-17 12:20:12
|
<Lucas_WMDE>
|
*the terminal
|
|
2026-04-17 12:20:17
|
<Lucas_WMDE>
|
brain no worky good anymore apparently
|
|
2026-04-17 12:20:37
|
<A_smart_kitten>
|
real
|
|
2026-04-17 12:21:14
|
<Lucas_WMDE>
|
fixed, thanks
|
|
2026-04-17 12:22:52
|
<A_smart_kitten>
|
np :) thanks for the comment. patch incoming probably in ($how-long-it-takes-me-to-type-a-reasonable-commit-message + 2) minutes
|
|
2026-04-17 12:28:53
|
<A_smart_kitten>
|
Lucas_WMDE: it appears that this may be the second time that I'm uploading a patch to move around some FlaggedRevs config in order to fix what the config variables' effective values are in production; which isn't a lot, but it's weird that it happened twice. (TM)
|
|
2026-04-17 12:28:54
|
<A_smart_kitten>
|
the first being https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/1227385
|
|
2026-04-17 12:29:41
|
<Lucas_WMDE>
|
watch out, you don’t want to look like you’re responsible for FlaggedRevs ;)
|
|
2026-04-17 12:30:12
|
<A_smart_kitten>
|
AAAAAAAAAAAAAAAAA
|
|
2026-04-17 12:30:35
|
<A_smart_kitten>
|
i should start prefixing my flaggedrevs-related commits with a disclaimer or something huh
|
|
2026-04-17 12:31:13
|
<A_smart_kitten>
|
"by uploading this patch, i am not claiming responsiblity for things to do with flaggedrevs in general"
|
|
2026-04-17 12:31:43
|
<Raine>
|
A_smart_kitten: we're working on making that the default :D
|
|
2026-04-17 12:32:24
|
<Raine>
|
that's what the ownership talk is about, I can find the email if you're curious (was sent to wikitech-l@ iirc)\
|
|
2026-04-17 12:32:58
|
<A_smart_kitten>
|
Raine: oh yeah! i actually want to reply to that email with some thoughts but i haven't got around to doing it yet. i am cautiously very optimistic about it though :)
|
|
2026-04-17 12:33:34
|
<Raine>
|
A_smart_kitten: <3 very happy to hear that
|
|
2026-04-17 12:34:07
|
<Raine>
|
and more feedback more better ^_^
|
|
2026-04-17 12:52:34
|
<A_smart_kitten>
|
pfft Lucas_WMDE I edit-conflicted with you while adding you as a reviewer. you had already +1ed it before my edit to add you went through :p
|
|
2026-04-17 12:52:42
|
<Lucas_WMDE>
|
>:D
|
|
2026-04-17 12:53:01
|
<Lucas_WMDE>
|
A_smart_kitten: I was wondering if it might qualify for an emergency deploy
|
|
2026-04-17 12:53:07
|
<Lucas_WMDE>
|
it’s not clear to me how urgent / “bad” the task is
|
|
2026-04-17 12:53:10
|
<Lucas_WMDE>
|
but probably not tbh
|
|
2026-04-17 12:54:26
|
<A_smart_kitten>
|
Lucas_WMDE: tbh I guess that might be a question for the enwikinews folks. 'normally' i'd probably be inclined to say that this change would be non-urgent, but enwikinews is working against a deadline for closure
|
|
2026-04-17 12:55:34
|
<A_smart_kitten>
|
i guess the impact of the current config might be as described at https://phabricator.wikimedia.org/T423512#11827523
|
|
2026-04-17 12:56:58
|
<A_smart_kitten>
|
with the current information, i would probably be _inclined_ to say that it might not qualify as wiki-breaking enough
|
|
2026-04-17 12:57:55
|
<Lucas_WMDE>
|
hm, they have 2½ weeks left, if the deploy waits until monday then it’s 2 weeks
|
|
2026-04-17 12:58:33
|
<Lucas_WMDE>
|
I’ll ask, doesn’t hurt
|
|
2026-04-17 12:58:37
|
<A_smart_kitten>
|
ack
|
|
2026-04-17 13:12:51
|
<A_smart_kitten>
|
[discussion moved to #wikimedia-operations]
|